Enforce safe access to the user shared array buffers

kriszyp · Jan 2, 2025 · 3a18645 · 3a18645
1 parent 2fd2a4c
commit 3a18645
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/read.js b/read.js
@@ -401,17 +401,23 @@ export function addReadMethods(
 					keySize = this.writeKey(id, keyBytes, 4);
 				}
 			};
-			setKeyBytes();
-			let sharedBuffer = getUserSharedBuffer(
-				env.address,
-				keySize,
-				defaultBuffer,
-				options?.callback,
-			);
-			sharedBuffer.notify = () => {
+			let userSharedBuffers =
+				this._userSharedBuffers || (this._userSharedBuffers = new Map());
+			let sharedBuffer = userSharedBuffers.get(id.toString());
+			if (!sharedBuffer) {
 				setKeyBytes();
-				return notifyUserCallbacks(env.address, keySize);
-			};
+				sharedBuffer = getUserSharedBuffer(
+					env.address,
+					keySize,
+					defaultBuffer,
+					options?.callback,
+				);
+				userSharedBuffers.set(id.toString(), sharedBuffer);
+				sharedBuffer.notify = () => {
+					setKeyBytes();
+					return notifyUserCallbacks(env.address, keySize);
+				};
+			}
 			return sharedBuffer;
 		},