Solving error launched running command gtt config #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nor VISUAL environnement variables are set
|
This PR fix #96 |
cgdobre
previously requested changes
Jun 7, 2020
src/include/filesystem.js
Outdated
Comment on lines
28
to
34
| if (!editor && !(editor = process.env.EDITOR)) { | ||
| editor = "vi"; | ||
| } | ||
|
|
||
| return child_process.spawn(editor, [file], { | ||
| stdio: 'inherit' | ||
| }); |
There was a problem hiding this comment.
Hi! Thanks for your contribution. What you suggest would not work on Windows unfortunately. What do you think of bumping the open package from 0.0.5 to 7.0.4 and using:
Suggested change
| if (!editor && !(editor = process.env.EDITOR)) { | |
| editor = "vi"; | |
| } | |
| return child_process.spawn(editor, [file], { | |
| stdio: 'inherit' | |
| }); | |
| if (editor || (editor = process.env.EDITOR)) { | |
| return child_process.spawn(editor, [file], { | |
| stdio: 'inherit' | |
| }); | |
| } else { | |
| return async () => await open(file); | |
| } |
cgdobre
added a commit
that referenced
this pull request
Jun 7, 2020
all yarn-check contents - except open as it is handled in PR #113 - except csv-string as compatibility is unclear
better to use this as vi may not be available on windows
fix merge error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If neither EDITOR not VISUAL environnement variables are set an exception will be launched after running gtt config command. The modification runs "vi" editor as default if it is the case.