Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridAab isn't overflow-free yet #498

Closed
kpreid opened this issue Jun 21, 2024 · 1 comment
Closed

GridAab isn't overflow-free yet #498

kpreid opened this issue Jun 21, 2024 · 1 comment
Labels
area: data Things related to the data structures underlying the world, and the functions that manipulate them. kind: incomplete A feature is partially implemented; the current state of the code is inconsistent

Comments

@kpreid
Copy link
Owner

kpreid commented Jun 21, 2024

I removed the volume limit from GridAab, but it still has unrepresentable boxes, because it is represented in terms of origin and size, and the sizes as i32, not u32.

We need to either make the size u32 or store upper bounds instead of sizes. Probably upper bounds will lead to cleaner code.
@kpreid kpreid added kind: incomplete A feature is partially implemented; the current state of the code is inconsistent area: data Things related to the data structures underlying the world, and the functions that manipulate them. labels Jun 21, 2024
@kpreid
Copy link
Owner Author

kpreid commented Jul 4, 2024

Stored upper bounds in 6fdaa6d. Unsigned sizes in b30e3a5.

@kpreid kpreid closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: data Things related to the data structures underlying the world, and the functions that manipulate them. kind: incomplete A feature is partially implemented; the current state of the code is inconsistent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpreid