Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic chunk mesh ordering #485

Closed
kpreid opened this issue Apr 3, 2024 · 1 comment
Closed

Deterministic chunk mesh ordering #485

kpreid opened this issue Apr 3, 2024 · 1 comment
Labels
area: graphics kind: bug Something isn't working as it should

Comments

@kpreid
Copy link
Owner

kpreid commented Apr 3, 2024

I added parallel chunk updates without thinking very hard about the consequences, and now the glTF export fails nondeterministically, because ordering in the file is determined by ordering of the parallel operations.

Possible solutions:

  • Have the glTF exporter sort the meshes by their MeshIds.
  • Give ChunkedSpaceMesh a method to request deterministic updates (which could still be calculated in parallel, but with sorted sequential callbacks).
@kpreid kpreid added kind: bug Something isn't working as it should area: graphics labels Apr 3, 2024
@kpreid
Copy link
Owner Author

kpreid commented Apr 3, 2024

Fixed by sorting in 590de4d.

@kpreid kpreid closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics kind: bug Something isn't working as it should
Projects
None yet
Development

No branches or pull requests

1 participant