Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM builds failing to produce wasm output #349

Closed
kpreid opened this issue Feb 16, 2023 · 2 comments
Closed

WASM builds failing to produce wasm output #349

kpreid opened this issue Feb 16, 2023 · 2 comments

Comments

@kpreid
Copy link
Owner

kpreid commented Feb 16, 2023

I am having a problem where updating the wasm-bindgen is causing there to be no all-is-cubes-wasm/dist/*.wasm output. Further investigation is needed, but I'm filing this issue to start making notes.

Presumably it is some kind of change in how wasm-bindgen interacts with wasm-pack and/or webpack. I've been thinking about getting rid of webpack since I'm not bundling other JS libraries, so that might be one solution.

My cargo installed versions of wasm-bindgen-cli and wasm-pack are up-to-date (0.2.84 and 0.10.3).
kpreid added a commit that referenced this issue Feb 16, 2023
@kpreid
Hold back wasm-bindgen dependency due to bug.
b4fb095 
Further investigation is needed; this is so that we can update deps
otherwise without breaking anything.

#349
@kpreid
Copy link
Owner Author

kpreid commented Mar 10, 2023

The problem seems to be fixed as of fe8a822, where I have indeed gotten rid of webpack (and NPM).

@kpreid
Copy link
Owner Author

kpreid commented Mar 10, 2023

All leftovers cleaned up now.

@kpreid kpreid closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpreid