Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture-only block updates are incomplete #342

Closed
kpreid opened this issue Jan 25, 2023 · 1 comment
Closed

Texture-only block updates are incomplete #342

kpreid opened this issue Jan 25, 2023 · 1 comment
Labels
kind: bug Something isn't working as it should

Comments

@kpreid
Copy link
Owner

kpreid commented Jan 25, 2023

When a block is replaced with another block of the same shape, we try to keep the geometry and modify the texture. This only works as intended if the BlockMesh uses exclusively texture colors and not vertex colors, but it is not (even though the code looks like it is doing what it's supposed to); this is visible in the UI buttons having colors left over from the opposite toggle state.

This problem should be easy enough to fix if we can just add the right instrumentation to see what it's doing…

(Note that the UI buttons should also be setting their animation hint to indicate that they might be replaced; doing that would hide this bug.)

@kpreid kpreid added the kind: bug Something isn't working as it should label Jan 25, 2023
@kpreid
Copy link
Owner Author

kpreid commented Jun 1, 2023

Fixed by 2a6d136.

used_any_vertex_colors was not being set true for ordinary colored vertices, only the ones produced by failing to allocate a texture.

@kpreid kpreid closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working as it should
Projects
None yet
Development

No branches or pull requests

1 participant