Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#46 AddToDoActivity 변환 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#46 AddToDoActivity 변환 #47

wants to merge 1 commit into from

Conversation

hardyeats
Copy link
Contributor

  • AddToDoActivity 코틀린으로 변환.
  • activity_main.xml : 리사이클러뷰가 툴바 밑으로 내려오도록 AppBarLayout, RecyclerView 위치 조정.
  • list_circle_try.xml : 레이아웃의 높이를 match_parent 에서 wrap_content 로 변경.

@hardyeats
#46
9aac47c 
- AddToDoActivity 코틀린으로 변환.
- activity_main.xml : 리사이클러뷰가 툴바 밑으로 내려오도록 AppBarLayout, RecyclerView 위치 조정.
- list_circle_try.xml : 레이아웃의 높이를 match_parent 에서 wrap_content 로 변경.
hardyeats
hardyeats commented Jul 30, 2017
View reviewed changes
app/src/main/java/com/example/avjindersinghsekhon/minimaltodo/AddToDoActivity.kt
setTheme(R.style.CustomStyle_DarkTheme)
userToDoReminderIconImageButton?.setImageDrawable(resources.getDrawable(R.drawable.ic_alarm_add_white_24dp))
userToDoRemindMeTextView?.setTextColor(Color.WHITE)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 이미지버튼이랑 텍스트뷰를 부를 때 자꾸 NPE가 나서 그냥 물음표를 붙여서 피했는데요.
그래서 얘네들이 (어두운 테마에 어울리는) 흰색으로 바뀌지가 않네요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hardyeats