Fix misuse of reified type parameters

[lukellmann]

KT-52469 issues warnings for Kord.getGlobalApplicationCommandOf, Kord.getGlobalApplicationCommandOfOrNull and VoiceState.getChannelOrNull since Kotlin 2.1.0-dev-7621.

[DRSchlaubi]

I do not understand this

[lukellmann]

This was a weird interaction between type inference and reified type parameters that will cause a warning with Kotlin 2.1.0. These functions were in fact buggy:

---

Kord.getGlobalApplicationCommandOf and Kord.getGlobalApplicationCommandOfOrNull were basically ignoring the type argument for T (it wasn't reified) and calling EntitySupplier.getGlobalApplicationCommandOf/EntitySupplier.getGlobalApplicationCommandOfOrNull with GlobalApplicationCommand for the reified T of the EntitySupplier functions unconditionally. Meaning you would get a ClassCastException instead of null for this code:

val command = kord.createGlobalUserCommand("user")
val shouldBeNull: GlobalChatInputCommand? = kord.getGlobalApplicationCommandOfOrNull<GlobalChatInputCommand>(command.id)
println(shouldBeNull)

The type parameter also had no bound so this was possible but also threw a ClassCastException:

val command = kord.createGlobalUserCommand("user")
val howShouldThisBeAString: String = kord.getGlobalApplicationCommandOf<String>(command.id)
println(howShouldThisBeAString)

With this PR, the first example works as expected and the second one no longer compiles.

---

VoiceState.getChannelOrNull also wasn't properly checking for and casting to BaseVoiceChannelBehavior but only for/to ChannelBehavior.

---

The warnings issued with Kotlin 2.1.0-dev-7621 are:

w: file:///.../kord/core/src/commonMain/kotlin/Kord.kt:505:32 Type argument for reified type parameter 'T' was inferred to the intersection of ['dev.kord.core.entity.application.GlobalApplicationCommand' & 'T & Any']. Reification of an intersection type results in the common supertype being used. This may lead to subtle issues and an explicit type argument is encouraged. This will become an error in a future release.

w: file:///.../kord/core/src/commonMain/kotlin/Kord.kt:510:32 Type argument for reified type parameter 'T' was inferred to the intersection of ['dev.kord.core.entity.application.GlobalApplicationCommand' & 'T? & Any']. Reification of an intersection type results in the common supertype being used. This may lead to subtle issues and an explicit type argument is encouraged. This will become an error in a future release.

w: file:///.../kord/core/src/commonMain/kotlin/entity/VoiceState.kt:63:98 Type argument for reified type parameter 'T' was inferred to the intersection of ['dev.kord.core.entity.channel.Channel' & 'dev.kord.core.behavior.channel.BaseVoiceChannelBehavior']. Reification of an intersection type results in the common supertype being used. This may lead to subtle issues and an explicit type argument is encouraged. This will become an error in a future release.

The important part is this:

Reification of an intersection type results in the common supertype being used.