Bring kord enum API closer to bit flags API #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done by only printing the raw value for Unknown entries in toString() and replacing the public Unknown constructor with a from() function in the companion object.
|
The function is named |
DRSchlaubi
approved these changes
Sep 3, 2023
lukellmann
added a commit
that referenced
this pull request
Sep 3, 2023
lukellmann
added a commit
that referenced
this pull request
Dec 26, 2023
The changes are the same as in #861, I simply forgot ArchiveDuration there.
lukellmann
added a commit
that referenced
this pull request
Dec 26, 2023
The changes are the same as in #861, I simply forgot ArchiveDuration there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by only printing the raw value for
Unknownentries intoString()and replacing the publicUnknownconstructor with afrom()function in the companion object.