gpu monitor on dcgm doc #2292
Open
gpu monitor on dcgm doc #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
+ Coverage 66.03% 66.05% +0.01%
==========================================
Files 457 457
Lines 53751 53751
==========================================
+ Hits 35495 35504 +9
+ Misses 15705 15696 -9
Partials 2551 2551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZiMengSheng
reviewed
Dec 11, 2024
| @@ -51,7 +51,7 @@ Currently, plugins from resmanager in Koordlet are mixed together, they should b | |||
| ## Proposal | |||
| ### Design | |||
|
|
|||
|  | |||
| __ | |||
|
|
||
| ### Goals | ||
| - The GPU NRI HOOK writes the Pod list and corresponding GPU list information to the mount file on the GPU NRI maintenance terminal. | ||
| - Adjust the logic of the DCGM component reading Pod and GPU: switch from reading from kubelet.sock to reading from the above mount file |
There was a problem hiding this comment.
we shouldn't modify the dcgm code
There was a problem hiding this comment.
It should be possible to implement through configuration and is being analyzed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
In order to be compatible with dcgm for GPU monitoring, adjust the adaptation of dcgm and GPU Hook NRI
Ⅱ. Does this pull request fix one issue?
fixes #2171
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test