Муканов Арман #233
Open
Муканов Арман #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zhelonkin
reviewed
Nov 29, 2023
| // Какие недостатки у такого подхода? | ||
| // Плохо читаем | ||
| // Не предоставляет детальную информацию при неудачном тестировании | ||
| // При изменении Person потребует изменений в методе AreEqual | ||
| Assert.True(AreEqual(actualTsar, expectedTsar)); |
There was a problem hiding this comment.
Внутри AreEqual есть рекурсивный вызов. Есть ли у него какие-то недостатки?
| [TestCase("00.0")] | ||
| [TestCase("+2.0")] | ||
| [TestCase("1111")] | ||
| public void IsValidNumber_ShouldBeTrue_WhenNumberIsValid(string value) |
There was a problem hiding this comment.
- Не хватает декомпозиции этого и следующего текстов, сейчас их названия буквально говорят "отдавать нет, когда нет" и "отдавать да, когда да"
- Не хватает кейсов с
null, только пустой строкой, только буквами/символами, разными десятичными разделителями, отбивкой разрядов, мб что-то еще - Не хватает кейсов с
precision,scale,onlyPositive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@a_zhelonkin