Ослина Анастасия #249
Open
Ослина Анастасия #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamnole
reviewed
Nov 16, 2024
| private readonly List<Rectangle> rectangles = []; | ||
| private readonly Point center = new(); | ||
|
|
||
| public CircularCloudLayouter(ICloudDistribution distribution) |
There was a problem hiding this comment.
Давай также сделаем возможность указывать позицию центра
| var rnd = new Random(); | ||
| for (var i = 0; i < rectanglesCount; i++) | ||
| { | ||
| var rectangleSize = new Size(rnd.Next(5, 30), rnd.Next(5, 30)); |
There was a problem hiding this comment.
Не плохо бы добавить, чтобы можно было управлять размерами прямоугольников
|
|
||
|
|
||
| [TestFixture] | ||
| public class CircularCloudLayouterTest |
| } | ||
|
|
||
| [Test] | ||
| public void CircularCloudLayouter_Initialize() |
There was a problem hiding this comment.
Из названия не понятно, что должно быть после инициализации
| public Size GetCloudSize() | ||
| { | ||
| if (rectangles.Count == 0) | ||
| throw new ArgumentException("Cloud cannot be empty."); |
There was a problem hiding this comment.
Мы выбрасываем ArgumentException хотя не передаем никаких аргументов. Может стоит немного поменять логику, например возвращать Size(0, 0)
ksamnole
reviewed
Nov 16, 2024
| } | ||
| } | ||
|
|
||
| public void SaveToPath(string fileName, string imagesPath) |
There was a problem hiding this comment.
Можно вынести в отдельный класс, что придерживаться Single Responsibility Principle. Рендерер как будто не про сохранение картинок
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksamnole