Зиновьева Милана #244
Зиновьева Милана #244
Conversation
cs/Samples/Samples.csproj
Outdated
| <PackageReference Include="xunit" Version="2.8.1" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.8.1"> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
не используемые зависимости стоит удалить
cs/TagsCloudVisualization/Spiral.cs
Outdated
|
|
||
| namespace Layouter; | ||
|
|
||
| class Spiral |
| foreach(Rectangle rectangle in rectangles){ | ||
| if (rectangleChecked.IntersectsWith(rectangle)) | ||
| return true; | ||
| } | ||
| return false; |
| [Test] | ||
| public void PutNextRectangle_PutSeveralRectangles(){ | ||
| Size rectangleSize = new Size(3, 7); | ||
| for(int i = 0;i < 20;i++){ |
There was a problem hiding this comment.
Стоит использовать автоформатирование кода. Если используешь райдер, можно настроить автоформатирование при коммите
cs/TagsCloudVisualization/Spiral.cs
Outdated
|
|
||
| namespace Layouter; | ||
|
|
||
| class Spiral |
| canvas.FillRectangle(rect.X, rect.Y, | ||
| rect.Width, | ||
| rect.Height); |
There was a problem hiding this comment.
При разбиении на строки, стоит либо на каждый аргумент выделять строку, либо в каждую строку помещать элементы вплоть до стандартной границы. Тут всё влезет на одну строку
| <Nullable>enable</Nullable> | ||
|
|
||
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> |
| } | ||
|
|
||
| [Test] | ||
| public void PutNextRectangle_LessThanAreaOfCircle() |
There was a problem hiding this comment.
Наоборот быть и не может, тест не имеет смысла
| circularCloudLayouter.GetRectangles.Count().Should().Be(1); | ||
| circularCloudLayouter.GetRectangles.Should().Contain(expectedRectangle); |
There was a problem hiding this comment.
collection.Should().ContainSingle()
https://fluentassertions.com/collections/
| { | ||
| circularCloudLayouter.PutNextRectangle(rectangleSize); | ||
| } | ||
| circularCloudLayouter.GetRectangles.Count().Should().Be(20); |
There was a problem hiding this comment.
collection.Should().HaveCount()
https://fluentassertions.com/collections/
|
|
||
| private List<Rectangle> rectangles; | ||
|
|
||
| public Point GetCenter => centercloud; |
| private ICanvas Draw(ICanvas canvas) | ||
| { | ||
| canvas.FillColor = Colors.Blue; | ||
| canvas.FontColor = Colors.Black; |
| return rectangle; | ||
| } | ||
|
|
||
| private Rectangle CanMove(Rectangle rectangle, bool isX, int direction) |
There was a problem hiding this comment.
Can в названии подразумевает, что вернется bool из метода и он не будет что-то менять. Стоит переименовать
| var movedRectangle = new Rectangle( | ||
| new Point(rectangle.X + shiftPoint.X, rectangle.Y + shiftPoint.Y), | ||
| rectangle.Size); |
There was a problem hiding this comment.
Посмотри на with expression
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/with-expression
| drawingTagsCloud.SaveToFile("Failed.png"); //сохраняется в bin | ||
| Console.WriteLine("Tag cloud visualization saved to file Failed.png"); |
| <ItemGroup> | ||
| <PackageReference Include="NUnit" Version="3.14.0" /> | ||
| <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.8.1"> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Include="NUnit.Framework" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Неиспользуемые пакеты стоит удалять из проекта
| do | ||
| { | ||
| Point nextPoint = spiral.GetNextPoint(); | ||
| tempRectangle = new Rectangle(new Point(nextPoint.X, nextPoint.Y), rectangleSize); |
There was a problem hiding this comment.
так же можно было использовать with expression
| private readonly System.Drawing.Point centercloud; | ||
| private readonly List<Rectangle> rectangles; | ||
|
|
||
| public DrawingTagsCloud(System.Drawing.Point center, List<Rectangle> rectanglesInput) |
There was a problem hiding this comment.
Указание типа точки можно сделать короче
No description provided.