Кашин Александр #22
Open
Кашин Александр #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,61 @@ | |||
| namespace HomeExercise.Tasks.ObjectComparison; | |||
|
|
|||
| public class TestPersonBuilder | |||
There was a problem hiding this comment.
Молодец, что сделал билдер для тестов, код стал читаемее :)
|
|
||
| public class TestPersonBuilder | ||
| { | ||
| private const string DEFAULT_NAME = ""; |
There was a problem hiding this comment.
Кажется, эти константы не нужны, можно вынести дефолтные значения в сами методы
There was a problem hiding this comment.
Думаю тогда лучше значения по умолчанию присваивать сразу же полям класса или же вовсе убрать их, если нет специфичных значений. В таком случае можно будет сразу же сделать Create().Build() без вызова методов настройки полей.
There was a problem hiding this comment.
Убрал явное присваивание значений по-умолчанию.
Testing/Basic/Homework/1. ObjectComparison/TestPersonBuilder.cs
Outdated
Show resolved
Hide resolved
Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs
Outdated
Show resolved
Hide resolved
Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs
Outdated
Show resolved
Hide resolved
added 3 commits
November 5, 2024 22:18
Добавил константы для текстовок, перенес повторяющиеся проверки в TestCase
Исключил Id из проверки в наследниках, убрал лишние константы
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.