Рыбин Леонид #17
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| bin/ | ||
| obj/ | ||
| .vs/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.11.35327.3 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Basic", "Basic.csproj", "{3C8EF388-9BF7-47CF-8B51-CA46F08B9253}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {3C8EF388-9BF7-47CF-8B51-CA46F08B9253}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {3C8EF388-9BF7-47CF-8B51-CA46F08B9253}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {3C8EF388-9BF7-47CF-8B51-CA46F08B9253}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {3C8EF388-9BF7-47CF-8B51-CA46F08B9253}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(SolutionProperties) = preSolution | ||
| HideSolutionNode = FALSE | ||
| EndGlobalSection | ||
| GlobalSection(ExtensibilityGlobals) = postSolution | ||
| SolutionGuid = {54C706B2-21C4-4C49-A162-2E765ACC0F80} | ||
| EndGlobalSection | ||
| EndGlobal | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | ||
| <s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=ac147a29_002D1949_002D44a0_002D9289_002Dab17f1aa8756/@EntryIndexedValue"><SessionState ContinuousTestingMode="0" IsActive="True" Name="All tests in category 'ToRefactor'" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session">
 | ||
| <Or>
 | ||
| <Category>ToRefactor</Category>
 | ||
| <TestAncestor>
 | ||
| <TestId>NUnit3x::3C8EF388-9BF7-47CF-8B51-CA46F08B9253::net8.0::HomeExercise.Tasks.NumberValidator.NumberValidatorTests</TestId>
 | ||
| </TestAncestor>
 | ||
| </Or>
 | ||
| </SessionState></s:String></wpf:ResourceDictionary> | ||
This comment was marked as off-topic.
Sorry, something went wrong. There was a problem hiding this comment. Я погуглил и вроде как файл DotSettings.user добавляют в .gitignore. Это обязательно ? There was a problem hiding this comment. В DotSettings.user обычно какие-то локальные настройки хранятся, скорее всего он создался из-за того что появился солюшен. В данном случае, да - его логично заигнорить. В следующей домашке попробуй без солюшена редактировать проект, скорее всего такой проблемы просто не возникнет. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,79 @@ | ||
| using System.Collections; | ||
| using FluentAssertions; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace HomeExercise.Tasks.NumberValidator; | ||
|
|
||
| [TestFixture] | ||
| public class NumberValidatorTests | ||
| { | ||
| [TestCase(-1, 2, true, TestName = "NumberValidator_WithNegativePrecision_ThrowsException")] | ||
| [TestCase(0, 2, false, TestName = "NumberValidator_WithPrecisionEqualsZero_ThrowsException")] | ||
| [TestCase(1, -2, true, TestName = "NumberValidator_WithNegativeScale_ThrowsException")] | ||
| [TestCase(1, 2, false, TestName = "NumberValidator_WithScaleGreaterThanPrecision_ThrowsException")] | ||
| [TestCase(1, 1, true, TestName = "NumberValidator_WithScaleEqualsPrecision_ThrowsException")] | ||
| public void NumberValidation_ConstructorThrowsArgumentException(int precision, int scale, bool onlyPositive) | ||
|
There was a problem hiding this comment. Тут всё хорошо, править не будем, но на будущее: Сейчас теряются из вида условия, когда должна быть вкинута ошибка: There was a problem hiding this comment. И вот как можно сделать: |
||
| { | ||
| var action = () => new NumberValidator(precision, scale, onlyPositive); | ||
|
|
||
| action.Should().Throw<ArgumentException>(); | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
| } | ||
|
|
||
| [Test(Description = "NumberValidator_WithCorrectParameters_NotThrowException")] | ||
|
There was a problem hiding this comment. До сих пор не понимаю, для чего тут описание теста) Description - это не TestName, для атрибута [Test] за имя теста будет браться наименование метода. В данном случае я по имени метода всё прекрасно понимаю, что делается и что ожидается.
|
||
| public void NumberValidation_ConstructorDoesNotHaveArgumentException() | ||
| { | ||
| var action = () => new NumberValidator(1, 0, true); | ||
|
|
||
| action.Should().NotThrow(); | ||
| } | ||
|
|
||
| [TestCaseSource(nameof(ValidNumbersCases))] | ||
| [TestCaseSource(nameof(InvalidNumbersCases))] | ||
| [TestCaseSource(nameof(InvalidInputCases))] | ||
| public bool IsValidNumber_WorksCorrectly(int precision, int scale, bool onlyPositive, string value) | ||
| { | ||
| return new NumberValidator(precision, scale, onlyPositive).IsValidNumber(value); | ||
| } | ||
|
|
||
| public static IEnumerable ValidNumbersCases | ||
| { | ||
| get | ||
| { | ||
| yield return new TestCaseData(1, 0, true, "0").SetName("ForZero_WithCorrectParams_ReturnTrue").Returns(true); | ||
| yield return new TestCaseData(2, 1, true, "0.0").SetName("ForZero_WithZeroFractionalPartAndDot_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(2, 1, true, "0.1").SetName("ForZero_WithNonZeroFractionalPartAndDot_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(2, 1, true, "0,1").SetName("ForZero_WithNonZeroDecimalPartAndComma_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(2, 0, true, "+1").SetName("ForPositiveInteger_WithSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(3, 1, true, "+1.1").SetName("ForPositiveDecimal_WithDotAndSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(3, 1, true, "+1,1").SetName("ForPositiveDecimal_WithCommaAndSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(2, 0, false, "-1").SetName("ForNegativeInteger_WithSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(3, 1, false, "-1.1").SetName("ForNegativeDecimal_WithDotAndSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(3, 1, false, "-1,1").SetName("ForNegativeDecimal_WithCommaAndSign_ReturnTrueOnCorrectParams").Returns(true); | ||
| yield return new TestCaseData(7, 2, true, "671,23").SetName("ForRealDecimal_WithCorrectParameters_ReturnTrue").Returns(true); | ||
| } | ||
| } | ||
|
|
||
| public static IEnumerable InvalidNumbersCases | ||
| { | ||
| get | ||
| { | ||
| yield return new TestCaseData(2, 0, true, "-1").SetName("ForNegativeInteger_WithMinusSign_OnlyPositiveIsFalse").Returns(false); | ||
|
There was a problem hiding this comment. Вот тут что-то не то "ForNegativeInteger_WithMinusSign" - у нас уже есть информация, что на входе отрицательное целое, зачем уточнять, что оно со знаком?) Может отрицательное без знака как-то быть?) There was a problem hiding this comment. Можно 2 теста добавить: один ForDecimal, другой ForInteger |
||
| yield return new TestCaseData(3, 2, true, "4321.5").SetName("ForDecimal_WithIncorrectPrecision_ReturnFalse").Returns(false); | ||
|
There was a problem hiding this comment. Вот я вижу тест для decimal, логичный вопрос возникает: а где для integer такой же? |
||
| yield return new TestCaseData(3, 0, true, "+145").SetName("ForPositiveDecimal_WithPlusSign_PrecisionCalculationAccountPlusSign").Returns(false); | ||
|
There was a problem hiding this comment. "ForPositiveDecimal" - а в тесте integer |
||
| yield return new TestCaseData(3, 0, false, "-124").SetName("ForNegativeDecimal_WithMinusSign_PrecisionCalculationAccountMinusSign").Returns(false); | ||
|
There was a problem hiding this comment. Также - в тесте передаем integer, а в наименовании decimal |
||
| } | ||
|
There was a problem hiding this comment. Вот сейчас, когда все тесты однообразно проименованы, я невооруженным глазом вижу:
|
||
| } | ||
|
|
||
| public static IEnumerable InvalidInputCases | ||
| { | ||
| get | ||
| { | ||
| yield return new TestCaseData(10, 9, true, "127.0.0.1").SetName("ForNumber_WithNonRealNumberFormat_ReturnFalse").Returns(false); | ||
| yield return new TestCaseData(2, 0, true, "").SetName("ForNumber_IsEmptyString_ReturnFalse").Returns(false); | ||
|
There was a problem hiding this comment. Вот тут хорошо просто зайдет "ForEmptyString_ReturnFalse" - префикс "ForNumber" только путает |
||
| yield return new TestCaseData(2, 1, true, ".0").SetName("ForNumber_WithMissingIntegerPart_ReturnFalse").Returns(false); | ||
| yield return new TestCaseData(2, 0, true, "0.").SetName("ForNumber_WithMissingFractionalPart_ReturnFalse").Returns(false); | ||
| yield return new TestCaseData(10, 2, true, "abcde.f").SetName("ForNumber_WithNonDigitCharacters_ReturnFalse").Returns(false); | ||
|
There was a problem hiding this comment. Как будто бы этот тест дублирует первый - тут нужен один с понятным названием "ForNotNumberInput_ReturnFalse" |
||
|
|
||
| } | ||
This comment was marked as resolved.
Sorry, something went wrong. There was a problem hiding this comment. Я переписал название тестов в развернутом виде, но PascalCase требует каждое слово с большой буквы писать, но в названии теста там предложение обычное, и как-то не очень в предложении каждое слово с большой буквы писать.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong. |
||
| } | ||
| } | ||
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, вроде бы. Я помню он мне файл .sln предложил сохранить.