Савенко Дмитрий #15
Open
Савенко Дмитрий #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desolver
suggested changes
Nov 6, 2024
| @@ -35,6 +30,16 @@ public void CheckCurrentTsar_WithCustomEquality() | |||
| new Person("Vasili III of Russia", 28, 170, 60, null)); | |||
|
|
|||
| // Какие недостатки у такого подхода? | |||
| /* 1. Ограниченная расширяемость: | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| [TestCase("23,1", false, 2, 1, true, TestName = "IsValidNumber_ShouldReturnFalse_WhenExceedsPrecisionWithComma")] | ||
| [TestCase("23,1", false, 3, 0, true, TestName = "IsValidNumber_ShouldReturnFalse_WhenExceedsScaleWithComma")] | ||
| [TestCase("+1", false, 1, 0, true, TestName = "IsValidNumber_ShouldReturnFalse_WhenSignExceedsPrecision")] | ||
| public void IsValidNumber_ShouldReturnExpectedResult(string value, bool expectedResult, int precision, int scale, bool onlyPositive) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
28
to
29
| [TestCase("0", true, 1, 0, true, TestName = "IsValidNumber_ShouldReturnTrue_WhenSingleDigit")] | ||
| [TestCase("0.1", true, 2, 1, true, TestName = "IsValidNumber_ShouldReturnTrue_WhenValidNumberWithDecimalPoint")] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| using NUnit.Framework.Legacy; | ||
| using NUnit.Framework; | ||
| using FluentAssertions; | ||
| using System; | ||
|
|
||
| namespace HomeExercise.Tasks.NumberValidator; | ||
|
|
||
| [TestFixture] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
desolver
reviewed
Nov 6, 2024
| ClassicAssert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age); | ||
| ClassicAssert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height); | ||
| ClassicAssert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent); | ||
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
До конца не понял, что именно прибрать надо там, максимум что я понял, то название у "Проверка текущего царя"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VladSavitskiy