Шевырин Никита #14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| bin/ | ||
| obj/ | ||
| .vs/ | ||
| shpora-testing.sln |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .idea/ | ||
| Folder.DotSettings.user |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,215 @@ | ||
| | ||
| using System.Collections; | ||
| using FluentAssertions; | ||
| using FluentAssertions.Execution; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace HomeExercise.Tasks.NumberValidator; | ||
|
|
||
| [TestFixture] | ||
| public class NumberValidatorTests | ||
| { | ||
| [Test] | ||
| [Description("Проверяем, что конструктор NumberValidator не кидает исключения если входные параметры" + | ||
| "заданы верно: precision > 0 и 0 <= scale < precision")] | ||
| [TestCase(1, 0, true)] | ||
|
There was a problem hiding this comment. Давай добавим Description или название теста, а то просто по входным данным может быть непонятно, что мы тестируем |
||
| [TestCase(1, 0, false)] | ||
| [TestCase(12, 5, true)] | ||
| [TestCase(12, 5, false)] | ||
| public void NumberValidator_DoesNotThrowOnCreation_WithCorrectArguments( | ||
| int precision, | ||
| int scale, | ||
| bool onlyPositive) | ||
| { | ||
| new Action(() => new NumberValidator(precision, scale, onlyPositive)) | ||
| .Should() | ||
| .NotThrow(); | ||
| } | ||
|
|
||
| [Test] | ||
| [Description("Проверяем, что конструктор NumberValidator кидает ArgumentException, " + | ||
| "если аргумент scale имеет значение больше или равное precision")] | ||
| [TestCase(1, 2, false)] | ||
| [TestCase(1, 2, true)] | ||
| [TestCase(7, 9, true)] | ||
| [TestCase(7, 9, false)] | ||
| [TestCase(7, 7, true)] | ||
| [TestCase(7, 7, false)] | ||
| public void NumberValidator_ThrowsOnCreation_WithScale_BeingMoreOrEqualTo_Precision( | ||
| int precision, | ||
| int scale, | ||
| bool onlyPositive) | ||
| { | ||
| new Action(() => new NumberValidator(precision, scale, onlyPositive)) | ||
| .Should() | ||
| .Throw<ArgumentException>() | ||
| .WithMessage("precision must be a non-negative number less or equal than precision"); | ||
| } | ||
|
|
||
| [Test] | ||
| [Description("Проверяем, что конструктор NumberValidator кидает ArgumentException, " + | ||
| "если аргумент precision имеет значение меньше или равное нулю")] | ||
| [TestCase(-1, 2, false)] | ||
| [TestCase(-1, 2, true)] | ||
| [TestCase(0, 0, false)] | ||
| [TestCase(0, 0, true)] | ||
| public void NumberValidator_ThrowsOnCreation_WithPrecision_BeingLessOrEqualTo_Zero( | ||
| int precision, | ||
| int scale, | ||
| bool onlyPositive) | ||
| { | ||
| new Action(() => new NumberValidator(precision, scale, onlyPositive)) | ||
| .Should() | ||
| .Throw<ArgumentException>() | ||
| .WithMessage("precision must be a positive number"); | ||
| } | ||
|
|
||
| [Test] | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
| [Description("Проверяем, что конструктор NumberValidator кидает ArgumentException, " + | ||
| "если аргумент scale имеет значение меньше нуля")] | ||
| [TestCase(1, -2, true)] | ||
| [TestCase(1, -2, false)] | ||
| [TestCase(7, -1, true)] | ||
| [TestCase(7, -1, false)] | ||
| public void NumberValidator_ThrowsOnCreation_WithScale_BeingLessThan_Zero( | ||
| int precision, | ||
| int scale, | ||
| bool onlyPositive) | ||
| { | ||
| new Action(() => new NumberValidator(precision, scale, onlyPositive)) | ||
| .Should() | ||
| .Throw<ArgumentException>() | ||
| .WithMessage("precision must be a non-negative number less or equal than precision"); | ||
| } | ||
|
|
||
| [Test] | ||
| [Description("Проверяем, что метод IsValidNumber возвращает: " + | ||
| "1) true для корректных чисел если они положительны (параметр onlyPositive == true)" + | ||
| "2) false для некорректных и любых отрицательных чисел (параметр onlyPositive == true)" + | ||
| "3) true для корректных чисел с любым знаком (параметр onlyPositive == false)" + | ||
| "4) false для некорректных чисел с любым знаком (параметр onlyPositive == false)")] | ||
| [TestCaseSource(nameof(OnlyPositiveValidNumberCases))] | ||
| [TestCaseSource(nameof(OnlyPositiveInvalidNumberCases))] | ||
| [TestCaseSource(nameof(GeneralValidNumberCases))] | ||
| [TestCaseSource(nameof(GeneralInvalidNumberCases))] | ||
| public void IsValidNumber_Returns_ExpectedResult( | ||
| int precision, | ||
| int scale, | ||
| bool onlyPositive, | ||
| string number, | ||
| bool expectedResult) | ||
| { | ||
| new NumberValidator(precision, scale, onlyPositive) | ||
| .IsValidNumber(number) | ||
| .Should() | ||
| .Be(expectedResult); | ||
| } | ||
|
|
||
| public static object[] OnlyPositiveValidNumberCases() | ||
| { | ||
| var onlyPositiveCasesWithScaleOfZero = new[] | ||
| { | ||
| "1", "+0", "01", "00" | ||
| }.Select(number => new object[] | ||
| { | ||
| 2, 0, true, number, true | ||
| }); | ||
|
|
||
| var onlyPositiveCases = new[] | ||
| { | ||
| "0.0", "0,0", "0", "1.23", "+0.00", "01.10", "+0,00", "1,0" | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
| }.Select(number => new object[] | ||
| { | ||
| 4, 2, true, number, true | ||
| }); | ||
|
|
||
| return onlyPositiveCasesWithScaleOfZero | ||
| .Concat(onlyPositiveCases) | ||
| .ToArray<object>(); | ||
| } | ||
|
|
||
| public static object[] OnlyPositiveInvalidNumberCases() | ||
| { | ||
| var numbers = new[] | ||
| { | ||
| "000.0", "-0.00", "+0,00", "+1.23", "-1,23", "a.sd", | ||
| "0.000", "0.", ",00", "", null, " ", " ", "-", "+", | ||
| " 1.5", "0,2 ", "0 . 11" | ||
| }; | ||
|
|
||
| var onlyPositiveCasesWithScaleOfZero = | ||
| new[] | ||
| { | ||
| "-1", "+000", "0.0", "3.14", "-0.1" | ||
| } | ||
| .Concat(numbers) | ||
| .Select(number => new object[] | ||
| { | ||
| 3, 0, true, number, false | ||
| }); | ||
|
|
||
| var onlyPositiveCases = | ||
| numbers.Select(number => new object[] | ||
| { | ||
| 3, 2, true, number, false | ||
| }); | ||
|
|
||
| return onlyPositiveCasesWithScaleOfZero | ||
| .Concat(onlyPositiveCases) | ||
| .ToArray<object>(); | ||
| } | ||
|
|
||
| public static object[] GeneralValidNumberCases() | ||
| { | ||
| var onlyPositiveCasesWithScaleOfZero = new[] | ||
| { | ||
| "1", "+0", "01", "00", "-0", "+2", "-2" | ||
| }.Select(number => new object[] | ||
| { | ||
| 2, 0, false, number, true | ||
| }); | ||
|
|
||
| var onlyPositiveCases = new[] | ||
| { | ||
| "0.0", "0", "-0", "-1.23", "+0.00", "01.10", "-1,10", "+10.0" | ||
| }.Select(number => new object[] | ||
| { | ||
| 4, 2, false, number, true | ||
| }); | ||
|
|
||
| return onlyPositiveCasesWithScaleOfZero | ||
| .Concat(onlyPositiveCases) | ||
| .ToArray<object>(); | ||
| } | ||
|
|
||
| public static object[] GeneralInvalidNumberCases() | ||
| { | ||
| var numbers = new[] | ||
| { | ||
| "000.0", "-0.00", "+0,00", "+1.23", "-1,23", "a.sd", | ||
| "0.000", "0.", ",00", "", null, " ", " ", "-,0", | ||
| "+0,", " 1.5", "0,2 ", "0 . 11" | ||
| }; | ||
|
|
||
| var onlyPositiveCasesWithScaleOfZero = | ||
| new[] | ||
| { | ||
| "-1.0", "+000", "0.0", "3.14", "-0.1", "1111" | ||
| } | ||
| .Concat(numbers) | ||
| .Select(number => new object[] | ||
| { | ||
| 3, 0, false, number, false | ||
| }); | ||
|
|
||
| var onlyPositiveCases = | ||
| numbers.Select(number => new object[] | ||
| { | ||
| 3, 2, false, number, false | ||
| }); | ||
|
|
||
| return onlyPositiveCasesWithScaleOfZero | ||
| .Concat(onlyPositiveCases) | ||
| .ToArray<object>(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.