Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Брозовский Максим #12

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Брозовский Максим #12

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1c6f559
Homework is done
BMV989 Nov 3, 2024
e0e6f80
Refactor: NumberValidatorTests
BMV989 Nov 4, 2024
232b0cb
Remove duplicate tests
BMV989 Nov 5, 2024
3440c65
small change in one test
BMV989 Nov 5, 2024
bb6c13c
dealing with exclude all persons' ids
BMV989 Nov 6, 2024
d942723
another refactoring of NumberValidatorTests
BMV989 Nov 6, 2024
f85a528
small mistake in case's TestName
BMV989 Nov 6, 2024
0b113c5
small refactoring of NumberValidatorTests
BMV989 Nov 6, 2024
ff9fdc5
another small mistake in one of testcases
BMV989 Nov 6, 2024
46d831d
Fixing testcases' naming
BMV989 Nov 7, 2024
cdf2d70
small mistake in testcase
BMV989 Nov 7, 2024
ef2b03f
another pack of mistakes have been fixed
BMV989 Nov 7, 2024
4f1f011
add some remark in one of the tests
BMV989 Nov 7, 2024
537ba36
yet another pack of mistakes
BMV989 Nov 7, 2024
8f4d1f4
small mistake
BMV989 Nov 7, 2024
4d634a9
still some mistakes
BMV989 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using NUnit.Framework;
using NUnit.Framework.Legacy;
using FluentAssertions;

namespace HomeExercise.Tasks.ObjectComparison;
public class ObjectComparison
Expand All @@ -13,17 +14,9 @@ public void CheckCurrentTsar()

var expectedTsar = new Person("Ivan IV The Terrible", 54, 170, 70,
new Person("Vasili III of Russia", 28, 170, 60, null));

// Перепишите код на использование Fluent Assertions.
ClassicAssert.AreEqual(actualTsar.Name, expectedTsar.Name);
ClassicAssert.AreEqual(actualTsar.Age, expectedTsar.Age);
ClassicAssert.AreEqual(actualTsar.Height, expectedTsar.Height);
ClassicAssert.AreEqual(actualTsar.Weight, expectedTsar.Weight);

ClassicAssert.AreEqual(expectedTsar.Parent!.Name, actualTsar.Parent!.Name);
ClassicAssert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age);
ClassicAssert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height);
ClassicAssert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent);

actualTsar.Should().BeEquivalentTo(expectedTsar, options => options
.Excluding(p => p.Name == nameof(Person.Id) && p.DeclaringType == typeof(Person)));
}

[Test]
Expand All @@ -36,6 +29,9 @@ public void CheckCurrentTsar_WithCustomEquality()

// Какие недостатки у такого подхода?
ClassicAssert.True(AreEqual(actualTsar, expectedTsar));
// Нужно писать сам предикат AreEqual (лишний код в котором можно ошибиться)
// + его надо поддерживать (при расширении класса Person нужно менять логику AreEqual)
// В AreEqual нет Assert, значит при падении теста не будет информации о том как упал тест (причина падения)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рассмотри еще кейс, когда у царя поле parent будет указывать на уже встречающегося царя в родословной. Нам же ничего не мешает так сделать :)

Copy link
Author

@BMV989 BMV989 Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Случай несколько вырожден, но формально возможен.
В таком случае возникнет бесконечная рекурсия.
Рассмотрим простой случай: есть actualTsar и пусть actualTsar.Parent.Parent = actualTsar.
Тогда при сравнении AreEqual(actualTsar, actualTsar) мы будем сравнивать их Parent, но у них тоже есть Parent, а значит их мы тоже будем сравнивать и т. д.
Таким образом мы получим бесконечную последовательность вызовов AreEqual для каждого Parent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему вырожден?
Ты не смотри на это как в жизни реально есть, у тебя написан код, который такое допускает.
И т.к мы не можем менять с тобой сурсы, давай обложимся на уровне тестов хотя бы

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Окей согласен

}

private bool AreEqual(Person? actual, Person? expected)
Expand Down
112 changes: 92 additions & 20 deletions Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,103 @@

using NUnit.Framework;
using NUnit.Framework.Legacy;
using FluentAssertions;

namespace HomeExercise.Tasks.NumberValidator;

[TestFixture]
public class NumberValidatorTests
{
[Test]
public void Test()
{
Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, true));
Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, false));
Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
private const string PrecisionErrorMessage = "precision must be a positive number";
private const string ScaleErrorMessage = "precision must be a non-negative number less or equal than precision";

ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0"));
ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("00.00"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-0.00"));
ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+0.00"));
ClassicAssert.IsTrue(new NumberValidator(4, 2, true).IsValidNumber("+1.23"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+1.23"));
ClassicAssert.IsFalse(new NumberValidator(17, 2, true).IsValidNumber("0.000"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-1.23"));
ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("a.sd"));
[TestCase(-1, 0, PrecisionErrorMessage, TestName = "precision < 0")]
[TestCase(-10, 1, PrecisionErrorMessage, TestName = "precision < 0")]
[TestCase(0, 0, PrecisionErrorMessage, TestName = "precision == 0")]
[TestCase(0, 2, PrecisionErrorMessage, TestName = "precision == 0")]
[TestCase(5, -1, ScaleErrorMessage, TestName = "scale < 0")]
[TestCase(5, -6, ScaleErrorMessage, TestName = "scale < 0")]
[TestCase(1, 2, ScaleErrorMessage, TestName = "scale > precision")]
[TestCase(1, 10, ScaleErrorMessage, TestName = "scale > precision")]
[TestCase(1, 1, ScaleErrorMessage, TestName = "scale == precision")]
[TestCase(2, 2, ScaleErrorMessage, TestName = "scale == precision")]
public void NumberValidator_ThrowsArgumentException_WithInvalidParams(int precision, int scale, string msg)
{
Action act = () => new NumberValidator(precision, scale);
act.Should().Throw<ArgumentException>().WithMessage(msg);
}

[TestCase("2", 1, 0, true, TestName = "2 should be valid number")]
[TestCase("52", 2, 1, true, TestName = "52 should be valid number")]
[TestCase("-300", 4, 0, false, TestName = "-300 should be valid number")]
[TestCase("+300", 4, 0, true, TestName = "+300 should be valid number")]
[TestCase("-99", 3, 2, false, TestName = "-99 should be valid number")]
[TestCase("9999999", 7, 1, false, TestName = "9999999 should be valid number")]
[TestCase("2147483649", 10, 1, false, TestName = "Int overflow should be valid number")]
[TestCase("-1234567890", 11, 8, false, TestName = "-1234567890 should be valid number")]
[TestCase("0101010", 20, 12, false, TestName = "0101010 should be valid number")]
[TestCase("01110.01010", 10, 5, true, TestName = "01110.01010 should be valid number")]
[TestCase("01110,01010", 10, 5, true, TestName = "01110,01010 should be valid number")]
[TestCase("+01110,01010", 11, 5, true, TestName = "+01110,01010 should be valid number")]
[TestCase("-1234567890.1234567890", 21, 10, false, TestName = "-1234567890.1234567890 should be valid number")]
[TestCase("+0.0", 3, 1, false, TestName = "+0.0 should be valid number")]
[TestCase("0.000", 4, 3, true, TestName = "0.000 should be valid number")]
[TestCase("300.52", 5, 2, true, TestName = "300.52 should be valid number")]
[TestCase("+3.52", 15, 10, false, TestName = "+3.52 should be valid number")]
[TestCase("+300,52", 17, 10, false, TestName = "+300,52 should be valid number")]
[TestCase("1,23", 17, 10, false, TestName = "1,23 should be valid number")]
[TestCase("+100", 4, 1, true, TestName = "+100 should be valid number")]
[TestCase("100\n", 4, 2, true, TestName = "100\n should be valid number")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Каждый тест кейс - это тестирование какого-то конкретного случая. И этот случай хотелось бы описать словами, т.к сейчас мне придется лезть в код и смотреть почему этот аргумент валидный или наоборот невалидный.

Сейчас в случаях, где указаны просто аргументы в TestName'е, как будто нет смысла. Я и так смогу посмотреть аргументы, а мне важен что это за случай.

В случае с 100\n у меня вообще кажется в TestName'е при запуске тестов по итогу будет просто 100?) И как понять что было не так?

Это можно было бы назвать типа: When \n at the end of a number

public void IsValidNumber_ShouldBeTrue_WithValidParams(string value, int precision, int scale, bool onlyPositive) =>
new NumberValidator(precision, scale, onlyPositive)
.IsValidNumber(value)
.Should().BeTrue();

[TestCase("", 17, 10, false, TestName = "empty string should be invalid number")]
[TestCase(null, 17, 10, false, TestName = "null should be invalid number")]
[TestCase("II", 17, 10, false, TestName = "II should be invalid number")]
[TestCase("III", 17, 10, false, TestName = "III should be invalid number")]
[TestCase("VI", 17, 10, false, TestName = "VI should be invalid number")]
[TestCase("X", 17, 10, false, TestName = "X should be invalid number")]
[TestCase("ఎనమద", 4, 0 , true, TestName = "ఎనమద should be invalid number")]
[TestCase("తమమద", 4, 0 , true, TestName = "తమమద should be invalid number")]
[TestCase("0xFF", 4, 0, true, TestName = "0xFF should be invalid number")]
[TestCase("0x1A", 4, 0, true, TestName = "0x1A should be invalid number")]
[TestCase("0o75", 4, 0, true, TestName = "0o75 should be invalid number")]
[TestCase("0o44", 4, 0, true, TestName = "0o44 should be invalid number")]
[TestCase("0b1010", 6, 0, true, TestName = "0b1010 should be invalid number")]
[TestCase("0b01110.01010", 10, 5, true, TestName = "0b01110.01010 should be invalid number")]
[TestCase("seven.eleven", 17, 10, false, TestName = "seven.eleven should be invalid number")]
[TestCase("five/two", 17, 10, false, TestName = "five/two should be invalid number")]
[TestCase("11.11.11", 17, 10, false, TestName = "11.11.11 should be invalid number")]
[TestCase("+127.000.001", 17, 10, false, TestName = "+127.000.001 should be invalid number")]
[TestCase("11.22,33", 17, 10, false, TestName = "11.22.33 should be invalid number")]
[TestCase("55,22,33", 17, 10, false, TestName = "55.22.33 should be invalid number")]
[TestCase("+1\\2", 17, 10, false, TestName = "+1\\2 should be invalid number")]
[TestCase("X,Y", 3, 2, true, TestName = "X,Y should be invalid number")]
[TestCase("1\n.5", 3, 2, true, TestName = "1\n.5 should be invalid number")]
[TestCase("\n2.4", 3, 2, true, TestName = "\n2.4 should be invalid number")]
[TestCase("+-15", 3, 2, false, TestName = "+-15 should be invalid number")]
[TestCase("--10", 4, 2, false, TestName = "--10 should be invalid number")]
[TestCase("++1", 3, 0, true, TestName = "++1 should be invalid number")]
[TestCase("300_000", 17, 10, false, TestName = "300_000 should be invalid number")]
[TestCase("52 000", 17, 10, false, TestName = "52 000 should be invalid number")]
[TestCase("1/2", 17, 10, false, TestName = "1/2 should be invalid number")]
[TestCase("12 . 22", 17, 10, false, TestName = "12 . 22 should be invalid number")]
[TestCase("12 , 22", 17, 10, false, TestName = "12 , 22 should be invalid number")]
[TestCase("a.sd", 17, 10, false, TestName = "a.sd should be invalid number")]
[TestCase("-100", 4, 0, true, TestName = "-100 should be invalid number because onlyPositive is true")]
[TestCase("+1,23", 3, 2, true, TestName = "+1.23 should be invalid number because precision < 4")]
[TestCase("1.123", 4, 2, true, TestName = "1.123 should be invalid number because scale < 3")]
[TestCase("0.00", 5, 1, true, TestName = "0.000 should be invalid number because scale < 2")]
[TestCase("52", 1, 0, true, TestName = "52 should be invalid number because precision < 2")]
[TestCase("-300", 3, 0, false, TestName = "-300 should be invalid number because precision < 4")]
[TestCase("300", 2, 0, false, TestName = "300 should be invalid number because precision < 3")]
[TestCase("+100", 3, 0, false, TestName = "+100 should be invalid number because precision < 4")]
[TestCase("-1.23", 3, 2, false, TestName = "-1.23 should be invalid number because precision < 4")]
[TestCase("-1234567890.1234567890", 20, 10, false, TestName = "-1234567890.1234567890 should be invalid number because precision < 21")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут тоже: мне недостаточно просто знать аргументов, мне важно знать какой сценарий покрывает тест

public void IsValidNumber_ShouldBeFalse_WithInvalidParams(string value, int precision, int scale,
bool onlyPositive) =>
new NumberValidator(precision, scale, onlyPositive)
.IsValidNumber(value)
.Should().BeFalse();
}