New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Вильданов Савелий #10

Open

Saveliy21 wants to merge 7 commits into kontur-courses:master from Saveliy21:HomeWork

Saveliy21 commented Nov 3, 2024

@VladSavitskiy

Saveliy21 added 2 commits

November 3, 2024 23:46


          did NumberValidator

1c75d10


          did ObjectComparison

a266c8c

desolver suggested changes

View reviewed changes

Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs Outdated

Comment on lines 22 to 23

		expectedTsar.Parent.Should().BeEquivalentTo(actualTsar.Parent, options => options.
		Excluding(x =>x.Id));

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs

@@ @@ -36,6 +33,17 @@ public void CheckCurrentTsar_WithCustomEquality() @@
                       // Какие недостатки у такого подхода?
                       ClassicAssert.True(AreEqual(actualTsar, expectedTsar));
+                      /*
+                       * Недостатки:

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs Outdated

-                      ClassicAssert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age);
-                      ClassicAssert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height);
-                      ClassicAssert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent);

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs Outdated

+                      actualTsar.Should().BeEquivalentTo(expectedTsar, options => options.
+                          Excluding(x => x.Id).
+                          Excluding(x=>x.Parent));

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

-                      Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
-                      Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, false));
-                      Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
+                      try

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

+                  [TestCase(1,0,true,ExpectedResult = false,TestName = "Not catch Exception")]
+                  [TestCase(2,5,true,ExpectedResult = true,TestName = "Precision less then scale")]
+                  [TestCase(2,-3,true,ExpectedResult = true,TestName = "Negative scale")]
+                  public bool NumberValidator_Exceptions_Test(int precision, int scale, bool onlyPositive)

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

-                  [Test]
-                  public void Test()
+                  [TestCase(-1,2,true,ExpectedResult = true,TestName = "Negative precision")]
+                  [TestCase(1,0,true,ExpectedResult = false,TestName = "Not catch Exception")]

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

-                      ClassicAssert.IsFalse(new NumberValidator(17, 2, true).IsValidNumber("0.000"));
-                      ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-1.23"));
-                      ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("a.sd"));
+                  [Test, TestCaseSource(nameof(NumberValidatorTestCases))]

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

Comment on lines 36 to 45

+                          yield return new TestCaseData(new NumberValidator(8, 2, true), "0.0").Returns(true);
+                          yield return new TestCaseData(new NumberValidator(3, 0, true), "0").Returns(true);
+                          yield return new TestCaseData(new NumberValidator(4, 2, true), "-1.23").Returns(false);
+                          yield return new TestCaseData(new NumberValidator(4, 2, false), "-1.24").Returns(true);
+                          yield return new TestCaseData(new NumberValidator(5, 2, true), "1.253").Returns(false);
+                          yield return new TestCaseData(new NumberValidator(3, 2, false), "a.ds").Returns(false);
+                          yield return new TestCaseData(new NumberValidator(4, 2, true), "").Returns(false);
+                          yield return new TestCaseData(new NumberValidator(5, 2, true), "+-1.25").Returns(false);
+                          yield return new TestCaseData(new NumberValidator(5, 2, true), null).Returns(false);
+                          yield return new TestCaseData(new NumberValidator(3, 0, true), "1234").Returns(false);

This comment was marked as outdated.

Sign in to view

Saveliy21 added 4 commits

November 8, 2024 16:27


          Refactor ObjectComparison.cs

ef5b983


          Refactor ObjectComparison.cs

4e7e771


          Merge branch 'HomeWork' of https://github.com/Saveliy21/shpora-testing …

565ab8f

…into HomeWork


          Refactor NumberValidatorTests.cs

49844bf

desolver suggested changes

View reviewed changes

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

+                  [TestCase(2, 5, true, TestName = "Precision less then scale")]
+                  [TestCase(2, -3, true, TestName = "Negative scale")]
+                  [TestCase(-5, -3, true, TestName = "Negative scale and Precision less then scale ")]
+                  [TestCase(null, null, null, TestName = "Null input data")]

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

+                  [TestCase(4, 2, false, "-1.24", ExpectedResult = true)]
+                  [TestCase(4, 2, false, "-1.24", ExpectedResult = true)]
+                  public bool NumberValidator_ShouldReturnTrue_WithCorrectData(int precision, int scale, bool onlyPositive,
+                      String number)

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

Comment on lines 14 to 15

		public void NumberValidator_ShouldThrowArgumentException_WithIncorrectData(int precision, int scale,
		bool onlyPositive)

This comment was marked as outdated.

Sign in to view

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs Outdated

@@ @@ -1,48 +1,55 @@ @@
-              using NUnit.Framework;
+              using FluentAssertions;
+              using NUnit.Framework;
               namespace HomeExercise.Tasks.NumberValidator;
               [TestFixture]

This comment was marked as outdated.

Sign in to view


          Refactor NumberValidatorTests.cs

467e3e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet