Махлонов Дмитрий #210
Open
Махлонов Дмитрий #210
+910
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlazProject
reviewed
Dec 19, 2024
|
|
||
| namespace TagCloud.TextReader; | ||
|
|
||
| public record class TextReaderSettings(string Path, Encoding Encoding); |
There was a problem hiding this comment.
Не очень хорошо передавать напрямую текст, так как таким ридером не получится воспользоваться дважды для разных файлов. Тогда лучше здесь передавать класс настроек
There was a problem hiding this comment.
тут не совсем понял, там же не текст передается, а класс настроек в котором уже лежит путь до файла
| { | ||
| public List<string> ReadText() | ||
| { | ||
| return File.ReadLines(settings.Path, settings.Encoding) |
There was a problem hiding this comment.
Это уже похоже на объединение чтения и разделения на слова. Как тебе идея сделать отдельного разделителя и отдельного читателя?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.