Andronov Alexander #208
Open
Andronov Alexander #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrTimeChip
reviewed
Jan 31, 2024
| private int segmentsCount = 2; | ||
| private List<Vector2> directions = new List<Vector2>(); | ||
|
|
||
| public Rectangle[] Rectangles => rectangles.Select(Rectangle.Truncate).ToArray(); |
|
|
||
| public class TagCloudLayouter : ITagCloudLayouter | ||
| { | ||
| private int i; |
There was a problem hiding this comment.
Очень странное название, надо более говорящее.
| private readonly RenderOptions options; | ||
| private readonly IColorProvider colorProvider; | ||
|
|
||
| private readonly Size imageSize; |
Comment on lines
51
to
74
| private Font GetAdjustedFont(Graphics graphic, string text, Font originalFont, Size boxSize, int maxFontSize, int minFontSize, bool smallestOnFail) | ||
| { | ||
| for (int adjustedSize = maxFontSize; adjustedSize >= minFontSize; adjustedSize--) | ||
| { | ||
| Font testFont = new Font(originalFont.Name, adjustedSize, originalFont.Style); | ||
|
|
||
| SizeF newSize = graphic.MeasureString(text, testFont); | ||
|
|
||
| if (boxSize.Width > Convert.ToInt32(newSize.Width) && | ||
| boxSize.Height > Convert.ToInt32(newSize.Height)) | ||
| { | ||
| return testFont; | ||
| } | ||
| } | ||
|
|
||
| if (smallestOnFail) | ||
| { | ||
| return new Font(originalFont.Name, minFontSize, originalFont.Style); | ||
| } | ||
| else | ||
| { | ||
| return originalFont; | ||
| } | ||
| } |
|
|
||
| public Bitmap Render(WordLayout[] wordLayouts) | ||
| { | ||
| var rectangles = wordLayouts.Select(x => x.Box).ToArray(); |
|
|
||
| public Bitmap CreateCloud(Dictionary<string, int> frequencyDict) | ||
| { | ||
| var kvps = frequencyDict.OrderByDescending(x => x.Value) |
There was a problem hiding this comment.
Не самое лучшее название для переменной.
|
|
||
| foreach (var kvp in kvps) | ||
| { | ||
| var mul = TagCloudHelpers.GetMultiplier(kvp.Value, minFreq, maxFreq); |
There was a problem hiding this comment.
Странное стремление к сокращению всего и вся. Что за множитель из контекста непонятно совершенно, надо отразить в названии.
| } | ||
|
|
||
|
|
||
| private static WordExtractionOptions CreateWordExtractoroptions(Options clOptions) |
| { | ||
| var radians = angle * Math.PI / 180; | ||
| var tangent = Math.Tan(radians); | ||
| var x = 1f; |
There was a problem hiding this comment.
Окей, в комментах увидел, зачем. Но всё ещё такой же вопрос, зачем нам множитель, равный 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.