Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ослина Анастасия #15
base: master
Are you sure you want to change the base?
Ослина Анастасия #15
Changes from 1 commit
cf66fc4
a8cea67
82f5655
584a23e
7c68d9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Меня несколько смущает, что объект
Options
это синглтон, который позволяет себя модифицировать.Какой-то из компонентов может воспользоваться этим и поменять некоторые значения, ожидая, что у него личный экземпляр настроек, словно локальная переменная.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Несмотря на то, что по умолчанию Autofac регистрирует как per dependency, тут зарегистрирован конкретный объект
options
. Autofac не будет его копировать, поэтому шанс случайной модификации остаётся возможенThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Странно, что при неправильном вызове приложения выводится Exception в конце подсказки
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolvedupd: нет, не совсем.
Мне не понятно, почему команда сообщает о двух ошибках одновременно:
Кажется, в данном случае правильно показать только требуемые параметры, а не null reference exception.
В то же время важно сохранить настоящие исключения, чтобы в случае ошибок было понятно, как исправлять