feat: disable bubbletea #2321
feat: disable bubbletea #2321
Conversation
| } | ||
| }() | ||
|
|
||
| <-done |
There was a problem hiding this comment.
Ok this is a bit of a nasty cheat that more than one might have a hard time using in the future 😆
You're waiting here because nobody has sent data to it. But you also have the read inside the goroutine inside the case statement! Which one wins when done <- true happens inside the ticker.C?
The short answer is the asynchronous one, at the top level that simply returns. The second one, the one inside the for select will need an extra CPU cycle to leave the statement of the ticker.C then go back to the parent one, to finally read the "return" you have there, but at that point, the function is long gone.
May I propose you to use an errgroup or the tool we've been using so far for waiting for events from happening instead of generating yet another function "that waits for a condition"?
The other part this doesn't cover is that there is no timeout. This function will run forever if none of the conditions break the loop.
| @@ -24,8 +24,8 @@ import ( | |||
|
|
|||
| func main() { | |||
| argsWithProg := os.Args | |||
|
|
|||
| bubbleTeaBlacklist := []string{"completion", "help", "--help", "-h", "quota", "logs"} | |||
| fmt.Println(argsWithProg) | |||
There was a problem hiding this comment.
This seems like a debugging statement, might want to remove it.
Description
add ci flag so to test the provisioning of cluster in argo workflows
How to test
provision any cluster using cli and add additional flag "--ci"