Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the Merge request is dropped at least for starting some review and some test from your side
what it's being made
CLI
---k3s-extra-conf "--disable traefik,--write-kubeconfig-mode 0644,--flannel-iface eth1"
---k3s-servers-ips 10.0.0.11,10.0.0.12,10.0.0.13
-~
--k3s-ssh-private-key ~/.ssh/id_ed25519
~---K3s-agents-ips
(optionals if you want agent+ server---k3s-ssh-user vagrant
--extra-servers-args
--servers-private-ips
--servers-public-ips
usefulle when u have VPS/vm with public ip--servers-private-ips
LAN network eg:192.168.1.20,192.168.1.21
--ssh-user
--ssh-privatekey
NB1: i removed the agents CLI configuration, (for now), because i need to rethink how it will be done , i want to avoid, a huge CMD Line with infinite arguments and another process to deliver this PR. So to avoid wasting time searching a solution i prefer to split and give a functional K3S provisionning with only the
k3s servers
stuff , thek3s agents
is postpone SO, i'll need to discuss with kubefirst team , but i may some solutions for the huge CMD CLI ( like a config file) , but obviously, will need to make that another PR before thek3s agent
provisionningNB: i've also remove the
--k3s-*
awful prefix from argumentskubefirst-api has been updated according to your logic Add k3s backend kubefirst-api#281
go mod edit -replace github.com/kubefirst/kubefirst-api=../kubefirst-api
Gitops-Templates updated feat: add-k3s-scenario gitops-template#659
k3d
tempalteis being tested with Virtual machine (made by Vagrant), whihch involved a not fully ended delivery by CLI, because i don"t have the possibility to expose my box to a DNS, so all the finalizes are blocked byt
TLS-acme stuff
but basically if went to this line
https://github.com/DrummyFloyd/kubefirst-api/blob/fd69ab7fd02c58e5842ad9c20bc61161a3b8239e/providers/k3s/create.go#L188
i assumed that quite everything is being done when we are here.
TODO
k3s agents
provisionning- [ ] add Metallb as LoadBalancer=> remove to stay generic as possible, useservicelb
fromk3s
test
NB:: if you want my VagrantFile , do not hesitate!
have fun !
Resolves: #1748