--use-telemetry false not honnored - probably local

[6za]

Overview

It seems that because of bad binding of the flag --use-telemetry telemetry is not properly skipped on some flavor of installation.

I believe the issue reported is focused on local, that is been re-factored for 1.11.

Goals

• Review on 1.11 if local install --use-telemetry is honored
• Review on 1.11 if aws-github install --use-telemetry is honored
• Review on 1.11 if aws-gitlab install --use-telemetry is honored

Notes

• Possible regression issue due to local refactor of flags handling incomplete on 1.10.8.

Source: https://github.com/kubefirst/kubefirst/discussions/848

[converge]

tested a full install on local, it's working as expected. There is maybe a confusion how the flag should be used, the docs were updated to make it clear how to use use-telemetry flag.

#877

[timoguin]

tested a full install on local, it's working as expected. There is maybe a confusion how the flag should be used, the docs were updated to make it clear how to use use-telemetry flag.

#877

Perfect. I'm pretty sure I was using --use-telemetry false. I'll check it out and confirm.

[converge]

@timoguin our cobra library requires boolean values to be set as --flag-name=true/false , I agree it's a bit confusing, --flag-name true/false should also work but it isn't the case.

[timoguin]

@timoguin our cobra library requires boolean values to be set as --flag-name=true/false , I agree it's a bit confusing, --flag-name true/false should also work but it isn't the case.

I think a --disable-telemetry boolean flag might be more user friendly. Just a thought. 😊

[fharper]

Good suggestion @timoguin, I created this issue for the team #1021