Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry flag for clearer one #1021

Open
fharper opened this issue Dec 29, 2022 · 2 comments
Open

Update telemetry flag for clearer one #1021

fharper opened this issue Dec 29, 2022 · 2 comments
Labels
feature Something new good first issue Good for newcomers

Comments

@fharper
Copy link
Contributor

fharper commented Dec 29, 2022

What would you like to be added:

Instead of using --use-telemetry, let's change it for --disable-telemetry as suggested by @timoguin in this comment.

Why is this needed:

It will make it more clear for the users.

@6za
Copy link
Contributor

6za commented Jan 9, 2023

@timoguin
Copy link

https://github.com/kubefirst/kubefirst/discussions/1032

Just FYI, @6za, if you put issue numbers in the title or body of your commits or PRs, GitHub will automatically associate them.

There are some special keywords like Fixes #NUM that can do things like auto-close issues.

For reference:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants