Skip to content

Commit

Permalink
fix: bump runtime, update logic for dns verify (#1640)
Browse files Browse the repository at this point in the history
  • Loading branch information
echoboomer authored Jun 22, 2023
1 parent ec43286 commit 24e5e4d
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 7 deletions.
7 changes: 6 additions & 1 deletion cmd/aws/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,12 @@ func createAws(cmd *cobra.Command, args []string) error {
telemetryShim.Transmit(useTelemetryFlag, segmentClient, segment.MetricDomainLivenessStarted, "")

// verify dns
err := dns.VerifyProviderDNS("aws", cloudRegionFlag, domainNameFlag)
ns, err := awsClient.GetHostedZoneNameServers(domainNameFlag)
if err != nil {
return err
}

err = dns.VerifyProviderDNS("aws", cloudRegionFlag, domainNameFlag, ns)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/civo/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func createCivo(cmd *cobra.Command, args []string) error {
telemetryShim.Transmit(useTelemetryFlag, segmentClient, segment.MetricDomainLivenessStarted, "")

// verify dns
err := dns.VerifyProviderDNS(civo.CloudProvider, cloudRegionFlag, domainNameFlag)
err := dns.VerifyProviderDNS(civo.CloudProvider, cloudRegionFlag, domainNameFlag, nil)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/digitalocean/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ func createDigitalocean(cmd *cobra.Command, args []string) error {
}

// verify dns
err := dns.VerifyProviderDNS(digitalocean.CloudProvider, cloudRegionFlag, domainNameFlag)
err := dns.VerifyProviderDNS(digitalocean.CloudProvider, cloudRegionFlag, domainNameFlag, nil)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/vultr/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ func createVultr(cmd *cobra.Command, args []string) error {
}

// verify dns
err := dns.VerifyProviderDNS(vultr.CloudProvider, cloudRegionFlag, domainNameFlag)
err := dns.VerifyProviderDNS(vultr.CloudProvider, cloudRegionFlag, domainNameFlag, nil)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ require (
github.com/dustin/go-humanize v1.0.1
github.com/go-git/go-git/v5 v5.6.1
github.com/hashicorp/vault/api v1.9.0
github.com/kubefirst/runtime v0.1.64
github.com/kubefirst/runtime v0.1.65
github.com/rs/zerolog v1.29.0
github.com/sirupsen/logrus v1.9.0
github.com/spf13/cobra v1.7.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -711,8 +711,8 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/kubefirst/runtime v0.1.64 h1:V/MG+YH1OgK5Es2tm90q1oVIPaWIsRYUn59HI60DA6k=
github.com/kubefirst/runtime v0.1.64/go.mod h1:hbV3BuyzKp7hgMDLYQCuXFMn5ERl9pzqiotDDpRrLhc=
github.com/kubefirst/runtime v0.1.65 h1:t0xqZmTIylx+/p5WU6xg6PLl4MZEgoRf05Gmka08cNA=
github.com/kubefirst/runtime v0.1.65/go.mod h1:hbV3BuyzKp7hgMDLYQCuXFMn5ERl9pzqiotDDpRrLhc=
github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
github.com/ledongthuc/pdf v0.0.0-20220302134840-0c2507a12d80 h1:6Yzfa6GP0rIo/kULo2bwGEkFvCePZ3qHDDTC3/J9Swo=
Expand Down

0 comments on commit 24e5e4d

Please sign in to comment.