Skip to content

Commit

Permalink
Merge branch 'telemetry-shift' of github.com:kubefirst/kubefirst-api …
Browse files Browse the repository at this point in the history
…into telemetry-shift
  • Loading branch information
jarededwards committed Oct 22, 2023
2 parents 6ec6cd2 + 1794dc2 commit 66cef8e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion internal/controller/argocd.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ func (clctrl *ClusterController) DeployRegistryApplication() error {
return err
}

// telemetry todo

if !cl.ArgoCDCreateRegistryCheck {
var kcfg *k8s.KubernetesClient
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (clctrl *ClusterController) StateStoreCredentials() error {
if err != nil {
msg := fmt.Sprintf("error creating google bucket %s: %s", clctrl.KubefirstStateStoreBucketName, err)
log.Error()
telemetry.SendCountMetric(clctrl.Telemetry, metrics.StateStoreCreateFailed, msg)
telemetry.SendCountMetric(clctrl.Telemetry, metrics.StateStoreCredentialsCreateFailed, msg)
return fmt.Errorf(msg)
}

Expand All @@ -142,7 +142,7 @@ func (clctrl *ClusterController) StateStoreCredentials() error {

objst, err := vultrConf.CreateObjectStorage(clctrl.KubefirstStateStoreBucketName)
if err != nil {
telemetry.SendCountMetric(clctrl.Telemetry, metrics.StateStoreCreateFailed, err.Error())
telemetry.SendCountMetric(clctrl.Telemetry, metrics.StateStoreCredentialsCreateFailed, err.Error())
log.Error(err.Error())
return err
}
Expand Down
2 changes: 1 addition & 1 deletion providers/vultr/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func DeleteVultrCluster(cl *pkgtypes.Cluster, segmentClient *telemetry.SegmentCl
log.SetReportCaller(false)
log.SetOutput(os.Stdout)

telemetry.SendCountMetric(segmentClient, metrics.ClusterInstallStarted, "")
telemetry.SendCountMetric(segmentClient, metrics.ClusterDeleteStarted, "")

// Instantiate vultr config
config := providerConfigs.GetConfig(cl.ClusterName, cl.DomainName, cl.GitProvider, cl.GitAuth.Owner, cl.GitProtocol, cl.CloudflareAuth.Token, "")
Expand Down

0 comments on commit 66cef8e

Please sign in to comment.