-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hard coded Kubernetes version for managment cluster #779
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR @muse-sisay 🎉 As for the change itself, we tend to stay away from using latest of anything instead of a pinned version for the reason you mention: by pinning the version we are sure that it's working properly with our stack. I think the fix would be more like updating the version number for 1.30.2 (latest available on DigitalOcean) instead or removing the version requirement. Let me do some testing on that Kubernetes version today to ensure it would work, so we can pin it. |
Happy to make my first contribution to Kubefirst @fharper! Let me know how your testing goes and I can pin the version to v1.30. I was skimming through repository and different cloud's had a different version pinned. For example in AWS directory is pinned to 1.26 while Google cloud uses "stable" release. Theoretically it Kubefirst should function similar across the different Kubernetes distribution. If we had to define the Kubernetes version in a central location where would the ideal place be? |
So the next step is to define which version we want to pin DigitalOcean on. @jarededwards is currently testing the latest available, but stumbled upon some issues he need to validate before we can confirm how to pin it. @jarededwards: once you are done and decided what is the next pinned version, please share it here so @muse-sisay can update his PR, and have his fix in kubefirst while becoming a new contributor 🎉 |
Greetings @fharper, I too ran into issues with Kubernetes v1.30 on DigitalOcean. I will copy paste my response from Slack as it also applies to other Kubernetes distrubution
Oldest supported release by DigitalOcean is v.128, which is EOL on 28 October 2024. I will test out 1.28 and report back.
Can we have a single version across the all cloud environments? Preferably defined in a single location that all Terraform modules can reference. |
As explained previously, it's not possible for different reasons. So let's just be sure we pin the right version for DigitalOcean right now. Let me check with @jarededwards where he is with his testing. |
Support for v1.27 was dropped on 28 June 2024. This commit pins the version to 1.28, which would be EOL on 28 October 2024.
Was this the version you & @jarededwards tested? Just to be sure caused I won't test it if it's already done. |
we had a chat in our community slack with @muse-sisay and we are going to take start working on the changes to address his comment here |
DigitalOcean ended support for Kubernetes v1.27 on 28 June 2024. As a result Kubefirst(Terraform) is not able to provision a cluster.
DigitalOcean Kubernetes Supported Releases
Description
To fix this issue, this PR removes the hard coded Kubernetes version and instead use
digitalocean_kubernetes_versions
datasource to fetch the latest version that DigitalOcean supports. Downside of this change it that the new Kubernetes release might introduce breaking changes.