Skip to content

Commit

Permalink
fix(azure): make dns resource group optional
Browse files Browse the repository at this point in the history
  • Loading branch information
mrsimonemms committed Nov 28, 2024
1 parent 1f7bb53 commit 5819471
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion azure-github/terraform/azure/cluster.tf
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ resource "kubernetes_secret_v1" "external_dns" {
"azure.json" = jsonencode({
tenantId = data.azurerm_client_config.current.tenant_id
subscriptionId = data.azurerm_client_config.current.subscription_id
resourceGroup = local.dns_zone_rg
resourceGroup = data.azurerm_dns_zone.external_dns[count.index].resource_group_name
useManagedIdentityExtension = true
userAssignedIdentityID = azurerm_kubernetes_cluster.kubefirst.kubelet_identity[0].client_id
})
Expand Down
2 changes: 1 addition & 1 deletion azure-github/terraform/azure/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ locals {
kubefirst = "true"
ProvisionedBy = "kubefirst"
}
use_dns_zone = try(local.dns_zone != "" && local.dns_zone_rg != "", false)
use_dns_zone = try(local.dns_zone != "", false)
vm_size = "<NODE_TYPE>"
}

Expand Down

0 comments on commit 5819471

Please sign in to comment.