-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ test: test for validate the physical cluster creation was added #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futjesus
force-pushed
the
kra-26-physical-cluster
branch
from
December 11, 2024 16:10
697feb6
to
78483a2
Compare
futjesus
force-pushed
the
kra-26-physical-cluster
branch
4 times, most recently
from
December 11, 2024 23:13
55a15af
to
fb0ad86
Compare
futjesus
force-pushed
the
kra-26-physical-cluster
branch
from
December 11, 2024 23:14
fb0ad86
to
c8367e1
Compare
…ntrypoint inside dockerfile
futjesus
force-pushed
the
kra-26-physical-cluster
branch
from
December 16, 2024 23:55
bef077c
to
123b323
Compare
futjesus
force-pushed
the
kra-26-physical-cluster
branch
from
December 17, 2024 20:44
8c39c9c
to
f2f086c
Compare
futjesus
changed the title
[🚧 WIP] ✅ test: test for validate the physical cluster creation was added
✅ test: test for validate the physical cluster creation was added
Dec 17, 2024
muse-sisay
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested downstream cluster provision in AWS and Civo with @futjesus. Here is an Argo workflow CI run in Civo. Looks good to me. But I would love someone else to review it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.