(ccc-libs)feat: Migrating saveFiles to cozy-client #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubleface
reviewed
Feb 2, 2023
| @@ -298,27 +300,35 @@ async function createFile(entry, options, method, fileId) { | |||
|
|
|||
| let fileDocument | |||
| if (method === 'create') { | |||
| fileDocument = await cozy.files.create(toCreate, createFileOptions) | |||
| const clientResponse = await client.save({ | |||
There was a problem hiding this comment.
On ne pourrait pas remplacer tout ça par
const clientResponse = await client.save({
_type: 'io.cozy.files',
type: 'file',
data: toCreate,
...createFileOptions,
...(file?._id ? {
_id: file._id,
_rev: file._rev
} : {})
})Et du coup on n'aurait plus besoin de distinguer via "method"
There was a problem hiding this comment.
Comme précisé sur mattermost, sera traité dans une autre carte et est référencé par #908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting the migration to cozy-client in saveFiles of the ccc-libs
Flagship app master Launch.js is already up-to-date for the new saveFiles prototype (client 1st arg)