Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable tkn-bundle test #1491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tisutisu
Copy link
Contributor

@tisutisu tisutisu commented Jan 23, 2025

Description

It will enable the tkn-bundle test and retry the fetchImage step, which was failing intermittently

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-5760

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from tkdchen and zregvart January 23, 2025 10:09
@tisutisu tisutisu changed the title chore: re enable tkn-bundle test chore: enable tkn-bundle test Jan 24, 2025
tests/build/tkn-bundle.go Outdated Show resolved Hide resolved
@chmeliik
Copy link
Contributor

/lgtm

@tisutisu
Copy link
Contributor Author

/retest

@mmorhun
Copy link
Contributor

mmorhun commented Jan 29, 2025

/lgtm

Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chmeliik, mmorhun
Once this PR has been reviewed and has the lgtm label, please ask for approval from tisutisu. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants