fix(KONFLUX-6229) fix ICM injection for multiarch images #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ICM injection step accepts the IMAGE param as the image to operate on, which needs to account for whether or not the IMAGE_APPEND_PLATFORM param is also set to true.
ralphbean
force-pushed
the
multiarch-icm-fix
branch
from
3395ad5 to
af6b374
Compare
|
This is a followup to #209. |
|
/retest |
ralphbean
added a commit
to konflux-ci/build-definitions
that referenced
this pull request
Jan 3, 2025
This ICM injection step accepts the IMAGE param as the image to operate on, which needs to account for whether or not the IMAGE_APPEND_PLATFORM param is also set to true. Incorporates: konflux-ci/build-tasks-dockerfiles#214 Fixes: https://issues.redhat.com/browse/KONFLUX-6229
|
I think this is successfully validated konflux-ci/oras-container#146 by way of konflux-ci/build-definitions#1785 |
This was referenced Jan 3, 2025
|
Ah, but there is a better fix in konflux-ci/build-definitions#1784. Let's use that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ICM injection step accepts the IMAGE param as the image to operate on, which needs to account for whether or not the IMAGE_APPEND_PLATFORM param is also set to true.
https://issues.redhat.com/browse/KONFLUX-6229