Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): exclude unused parameters from noop logger #36

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(lint): exclude unused parameters from noop logger #36

merged 1 commit into from
Oct 3, 2024

Conversation

thor
Copy link

@thor thor commented Oct 3, 2024

No description provided.

@thor thor requested a review from hanssto October 3, 2024 13:02
hanssto
hanssto approved these changes Oct 3, 2024
View reviewed changes
Copy link

@hanssto hanssto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it looks good. I don't know why and all, but it looks good.

@thor thor force-pushed the fix/happy-linter-happy-winter branch from 2c824d8 to d7fd8a2 Compare October 3, 2024 13:08
@thor thor merged commit 23386b6 into misc/update-golangci-lint Oct 3, 2024
34 of 36 checks passed
@thor thor deleted the fix/happy-linter-happy-winter branch October 3, 2024 13:38
hanssto pushed a commit that referenced this pull request Oct 4, 2024
@thor @hanssto
fix(lint): exclude unused parameters from noop logger (#36)
f8e045e
hanssto pushed a commit that referenced this pull request Oct 4, 2024
@thor @hanssto
fix(lint): exclude unused parameters from noop logger (#36)
a1614a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanssto hanssto hanssto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thor @hanssto