fix send buffer (log shipping) out of range panic #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
RebeccaMahany
previously approved these changes
Jan 31, 2025
| @@ -30,6 +30,9 @@ type SendBuffer struct { | |||
| sender sender | |||
| sendTicker *time.Ticker | |||
| isSending bool | |||
|
|
|||
| // logsJustPurged is used to prevent attempting to delete logs that were just purged | |||
| logsJustPurged bool | |||
There was a problem hiding this comment.
is this safe as bool and not atomic.Bool because we think it's adequately protected by the writeMutex? (it seems like it at first glance just wanted to double check)
There was a problem hiding this comment.
yes, it's protected by the writeMutex... trying to think of a better way to do this, but I think this will suffice
zackattack01
previously approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes panic: runtime error: index out of range [x] with length x that can occur in sendBuffer if buffer gets purged while waiting on network call to ship logs