Adopt Kokkos::StaticCrsGraph from "Core" and move Static{Ccs,Crs}Graph to namespace KokkosSparse::
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved Static{Ccs,Crs}Graph to namespace KokkosSparse and into their
own new header files
* Deprecate symbols in Kokkos namespace
* CRS counterpart used to come from the Containers subpackage in Kokkos
"Core" but now is transitioned to Kokkos Kernels.
Signed-off-by: Damien L-G <[email protected]>
Signed-off-by: Damien L-G <[email protected]>
dalg24
commented
Nov 6, 2024
Comment on lines
+31
to
+34
| using Kokkos::create_staticcrsgraph; | ||
| using Kokkos::GraphRowViewConst; | ||
| using Kokkos::maximum_entry; | ||
| using Kokkos::StaticCrsGraph; |
There was a problem hiding this comment.
I am not sure what to do about create_mirror[_view]
I certainly want to pull all overloads from Kokkos into KokkosSparse::
There was a problem hiding this comment.
I don't think Kokkos provides create_mirror... functions for any other non-view containers, right? Shall we just be consistent with that and move them into KokkosSparse namespace? Kokkos can make the suggestion in the deprecation message.
cwpearson
approved these changes
Nov 6, 2024
dalg24
commented
Nov 8, 2024
|
|
||
| } /* namespace TestStaticCrsGraph */ | ||
|
|
||
| TEST(NotSureWhatGoesThere, staticcrsgraph) { |
There was a problem hiding this comment.
Need to fix this before we merge
Let me know how you would like to call it
There was a problem hiding this comment.
We just put TestCategory and it gets set in e.g. test_common/Test_HIP.hpp for different backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what we agreed on, that is Kokkos "Core" is deprecating
Kokkos::StaticCrsGraphand we transition it to Kokkos Kernels intoKokkosSparse::.On 2nd thought we decided to give up on raising deprecation warnings because it was too tricky to guarantee same symbols and not emit diagnostics when the KokkosSparse:: versions are used.