ROT* HIP: testing and improving rocBLAS support for ROT* kernels #1594

lucbv · 2022-11-17T16:09:42Z

The rotation functions now support stream execution and proper pointer mode setting in the rocBLAS TPL interface layer.
This PR should fix the issue reported in #1593 and hopefully lead to fully clean build and tests on caraway!

The rotation functions now support stream execution and proper pointer mode setting in the rocBLAS TPL interface layer.

e10harvey

Does the function signature change from camelcase work with all versions of rocm? If not, we should throw a CMake error if a rocm version with the camelcase function names is detected.

kokkos-devops-admin · 2022-11-17T16:17:33Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

kokkos-devops-admin · 2022-11-17T16:20:55Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 160
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 168
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 121
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 120
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 83
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 170
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 219
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 105
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_ARMPL2110_Tpls_ARMPL2030_GCC1020

Build Num: 109
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (lucbv/kokkos-kernels)

Pull Request Author: lucbv

ndellingwood · 2022-11-17T17:31:57Z

Thanks @lucbv for the PR! I tested on caraway with rocblas enabled and compilation succeeds.

When enabling rocsparse as well I ran into other build errors

/home/ndellin/kokkos-kernels/sparse/impl/KokkosSparse_spgemm_rocSPARSE_impl.hpp:163:35: error: no matching function for call to 'rocsparse_Xcsrgemm_buffer_size'
  KOKKOS_ROCSPARSE_SAFE_CALL_IMPL(rocsparse_Xcsrgemm_buffer_size(
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ndellin/kokkos-kernels/sparse/src/KokkosSparse_Utils_rocsparse.hpp:117:52: note: expanded from macro 'KOKKOS_ROCSPARSE_SAFE_CALL_IMPL'
  KokkosSparse::Impl::rocsparse_internal_safe_call(call, #call, __FILE__, \

Looking at the rocsparse documentation it seems the "X" needs to be replaced by corresponding letter to the scalar type (s, d, c, or z)? Maybe this is resolved in #1589

ndellingwood · 2022-11-17T18:40:33Z

@lucbv after letting the unit tests run, there are runtime failures with the tests

[  FAILED  ] hip.rotmg_double_int_int_TestExecSpace
[  FAILED  ] hip.rotmg_double_int_size_t_TestExecSpace

More detailed output:

[ RUN      ] hip.rotmg_double_int_int_TestExecSpace
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.00251658 vs 2.23517e-17
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 32.5461 vs 7.22801e-14
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.000244141 vs 5.42101e-19
rotmg: param(1) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.9999 vs 2.22045e-15
rotmg: param(2) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.813558 vs 1.807e-15
rotmg: param(3) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 794.729 vs 5.29396e-12
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 167.711 vs 3.72529e-13
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 999999 vs 2.22045e-09
rotmg: param(2) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 4096 vs 9.09495e-12
rotmg: param(3) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.0233112 vs 5.92119e-17
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 9.41406 vs 5.42101e-14
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 5e-05 vs 1.11022e-19
rotmg: param(1) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 1192.07 vs 2.64698e-12
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 152.772 vs 3.72529e-13
rotmg: x1 is off
[  FAILED  ] hip.rotmg_double_int_int_TestExecSpace (6767 ms)

[  FAILED  ] hip.rotmg_double_int_int_TestExecSpace (6767 ms)
[ RUN      ] hip.rotmg_double_int_size_t_TestExecSpace
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.00251658 vs 2.23517e-17
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 32.5461 vs 7.22801e-14
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.000244141 vs 5.42101e-19
rotmg: param(1) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.9999 vs 2.22045e-15
rotmg: param(2) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.813558 vs 1.807e-15
rotmg: param(3) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 794.729 vs 5.29396e-12
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.02048 vs 1.36424e-16
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 999999 vs 2.22045e-09
rotmg: param(2) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 4096 vs 9.09495e-12
rotmg: param(3) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 0.0233112 vs 5.92119e-17
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 14.994 vs 3.33067e-14
rotmg: x1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 5e-05 vs 1.11022e-19
rotmg: param(1) is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 1192.07 vs 2.64698e-12
rotmg: d1 is off
/home/ndellin/kokkos-kernels/test_common/KokkosKernels_TestUtils.hpp:139: Failure
Expected: ((double)AT1::abs(val1 - val2)) <= ((double)AT3::abs(tol)), actual: 152.772 vs 3.72529e-13
rotmg: x1 is off
[  FAILED  ] hip.rotmg_double_int_size_t_TestExecSpace (5971 ms)

kokkos-devops-admin · 2022-11-17T19:21:45Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 160
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 168
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 121
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 120
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 83
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 170
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 219
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 105
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_ARMPL2110_Tpls_ARMPL2030_GCC1020

Build Num: 109
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	hip_rotation
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`af21fa8`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`63b15ad`
PR_LABELS	bug
PULLREQUESTNUM	1594
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2022-11-17T19:22:02Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey ]!

kokkos-devops-admin · 2022-11-17T19:22:09Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

ndellingwood · 2022-11-17T19:28:45Z

@lucbv @e10harvey should we merge this PR since it resolves the compilation errors reported in #1593
and I'll open a new issue for the runtime failures #1594 (comment) ?

e10harvey · 2022-11-17T19:46:05Z

I think that is a good path forward.

lucbv · 2022-11-21T15:28:32Z

@e10harvey the issue with the Camel case is related to differences between cublas and rocblas, I have not verified what prior versions of rocblas are doing. But we should certainly settle on which minimal version of rocblas we support to get started, I do not think that we have that defined anywhere and we should check what compatibility requirements are with rocm/5.2.0 which is the lowest rocm Kokkos supports.

lucbv · 2022-11-21T15:31:07Z

@ndellingwood unfortunately I have not tested rocpsarse in some time, let us focus on cleaning up rocblas first in our nightly builds.
The rocsparse issue seems fairly straightforward based on your comment though.

ROT* HIP: testing and improving rocBLAS support for ROT* kernels

af21fa8

The rotation functions now support stream execution and proper pointer mode setting in the rocBLAS TPL interface layer.

lucbv added the bug label Nov 17, 2022

lucbv requested review from ndellingwood and e10harvey November 17, 2022 16:09

lucbv self-assigned this Nov 17, 2022

e10harvey approved these changes Nov 17, 2022

View reviewed changes

ndellingwood merged commit 8948fb6 into kokkos:develop Nov 17, 2022

ndellingwood mentioned this pull request Nov 17, 2022

rotmg unit test failures with rocblas tpl #1597

Closed

lucbv deleted the hip_rotation branch November 21, 2022 15:31

ROT* HIP: testing and improving rocBLAS support for ROT* kernels #1594

ROT* HIP: testing and improving rocBLAS support for ROT* kernels #1594

Conversation

lucbv commented Nov 17, 2022

e10harvey left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Nov 17, 2022

kokkos-devops-admin commented Nov 17, 2022

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_ARMPL2110_Tpls_ARMPL2030_GCC1020

Jenkins Parameters

Using Repos:

ndellingwood commented Nov 17, 2022 • edited Loading

ndellingwood commented Nov 17, 2022

kokkos-devops-admin commented Nov 17, 2022

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_ARMPL2110_Tpls_ARMPL2030_GCC1020

Jenkins Parameters

kokkos-devops-admin commented Nov 17, 2022

kokkos-devops-admin commented Nov 17, 2022

ndellingwood commented Nov 17, 2022

e10harvey commented Nov 17, 2022

lucbv commented Nov 21, 2022

lucbv commented Nov 21, 2022

ndellingwood commented Nov 17, 2022 •

edited

Loading