Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config args to Accelerator init_tracker #959

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

rockerBOO
Copy link
Contributor

Related PR #792

Might need a "clean" for the config arguments but this may be better than nothing.

Screenshot 2023-11-18 at 16-25-24 Weights   Biases

@rockerBOO
Copy link
Contributor Author

This seems to error with tensorboard. May need to clean up the data so it isn't a mix of different values that are incompatible.

Traceback (most recent call last):
  File "/mnt/900/builds/sd-scripts/train_network.py", line 1118, in <module>
    trainer.train(args)
  File "/mnt/900/builds/sd-scripts/train_network.py", line 818, in train
    accelerator.init_trackers(
  File "/mnt/900/builds/sd-scripts/.venv/lib/python3.10/site-packages/accelerate/accelerator.py", line 615, in _inner
    return PartialState().on_main_process(function)(*args, **kwargs)
  File "/mnt/900/builds/sd-scripts/.venv/lib/python3.10/site-packages/accelerate/accelerator.py", line 2418, in init_trackers
    tracker.store_init_configuration(config)
  File "/mnt/900/builds/sd-scripts/.venv/lib/python3.10/site-packages/accelerate/tracking.py", line 71, in execute_on_main_process
    return PartialState().on_main_process(function)(self, *args, **kwargs)
  File "/mnt/900/builds/sd-scripts/.venv/lib/python3.10/site-packages/accelerate/tracking.py", line 203, in store_init_configuration
    self.writer.add_hparams(values, metric_dict={})
  File "/mnt/900/builds/sd-scripts/.venv/lib/python3.10/site-packages/torch/utils/tensorboard/writer.py", line 335, in add_hparams
    raise TypeError("hparam_dict and metric_dict should be dictionary.")
TypeError: hparam_dict and metric_dict should be dictionary.

@rockerBOO rockerBOO marked this pull request as draft November 21, 2023 19:16
@rockerBOO rockerBOO marked this pull request as ready for review November 22, 2023 02:18
@rockerBOO
Copy link
Contributor Author

Fixed tensorboard support. Only supports int, bool, str, float, and torch.Tensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant