Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bitsandbytes for 0.41.1 and fixed bugs with generate_controlnet_subsets_config for training #823

Merged
merged 7 commits into from
Sep 24, 2023

Conversation

sdbds
Copy link
Contributor

@sdbds sdbds commented Sep 16, 2023

No description provided.

@kohya-ss
Copy link
Owner

Thank you for this!

However, in sdxl (and dev) branch, bitsandbytes is now optional, and the user can choose the version of bitsandbytes from 0.35.0 and 0.41.1. In addition to that, if the user uses 0.41.1, I recommend to use the pre-built wheel form jllllll. So I think the dlls and main.py should be kept as is.

If it is fine, could you please make this only for the generate_controlnet_subsets_config issue?

@sdbds
Copy link
Contributor Author

sdbds commented Sep 18, 2023

Thank you for this!

However, in sdxl (and dev) branch, bitsandbytes is now optional, and the user can choose the version of bitsandbytes from 0.35.0 and 0.41.1. In addition to that, if the user uses 0.41.1, I recommend to use the pre-built wheel form jllllll. So I think the dlls and main.py should be kept as is.

If it is fine, could you please make this only for the generate_controlnet_subsets_config issue?

OK,i revert it and just fix config issue

@kohya-ss
Copy link
Owner

Thank you for updating, it is much appreciated. I will review the PR sooner.

I will be happy if you provide some description of the root issue when you have time.

@sdbds
Copy link
Contributor Author

sdbds commented Sep 18, 2023

Thank you for updating, it is much appreciated. I will review the PR sooner.

I will be happy if you provide some description of the root issue when you have time.

controlnet dataset use old dreambooth code so it judge reg dir and happend errors.

i changed it then use new dirs formatting with toml datasets(without num repeats)

@kohya-ss kohya-ss merged commit d5be812 into kohya-ss:dev Sep 24, 2023
1 check passed
@kohya-ss
Copy link
Owner

Thank you! I reproduced the issue. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants