Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify controlnet parameters name and change scripts name. #1821

Merged
merged 40 commits into from
Dec 7, 2024

Conversation

sdbds
Copy link
Contributor

@sdbds sdbds commented Dec 4, 2024

Multiple versions of the controlnet training script use three different parameter names, so the parameters are unified.
--controlnet_model_path
--controlnet_model_name_or_path
As well as renaming the initial version of the controlnet script to train_control_net.py

sdbds added 30 commits June 26, 2024 19:25
@kohya-ss
Copy link
Owner

kohya-ss commented Dec 4, 2024

Thank you for this! This makes sense.

However, it seems that this will be a breaking change when it is merged into the main branch in the future. I think breaking changes are allowed on the dev/sd3 branch. Therefore, although the name is not good, I think it is better to use controlnet_model_name_or_path used in train_controlnet.py.

@sdbds
Copy link
Contributor Author

sdbds commented Dec 4, 2024

Thank you for this! This makes sense.

However, it seems that this will be a breaking change when it is merged into the main branch in the future. I think breaking changes are allowed on the dev/sd3 branch. Therefore, although the name is not good, I think it is better to use controlnet_model_name_or_path used in train_controlnet.py.

OK, I'll use controlnet_model_name_or_path.

@kohya-ss kohya-ss merged commit abff4b0 into kohya-ss:sd3 Dec 7, 2024
1 check passed
@kohya-ss
Copy link
Owner

kohya-ss commented Dec 7, 2024

Thank you for updating!

I have added a script train_controlnet.py for backwards compatibility and displays a deprecation warning. It doesn't work on sd3 branch though, I should update the script before merging sd3 branch to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants