-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify controlnet parameters name and change scripts name. #1821
Conversation
# Conflicts: # sd3_train.py
This reverts commit 8b16535. # Conflicts: # library/train_util.py # sd3_train.py
Thank you for this! This makes sense. However, it seems that this will be a breaking change when it is merged into the main branch in the future. I think breaking changes are allowed on the dev/sd3 branch. Therefore, although the name is not good, I think it is better to use |
OK, I'll use |
Thank you for updating! I have added a script |
Multiple versions of the controlnet training script use three different parameter names, so the parameters are unified.
--controlnet_model_path
--controlnet_model_name_or_path
As well as renaming the initial version of the controlnet script to
train_control_net.py