Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown schedule-free optimizers to continue to module loader #1799

Closed

Conversation

rockerBOO
Copy link
Contributor

To support ProdigyPlusScheduleFree

pip install git+http://github.com/LoganBooker/prodigy-plus-schedule-free
--optimizer_type prodigyplus.ProdigyPlusScheduleFree
                    INFO     use prodigyplus.ProdigyPlusScheduleFree | {'weight_decay': 0.1}                                         train_util.py:4111
[Prodigy+ScheduleFree] Optimiser contains single param_group -- 'split_groups' has been disabled.

Related #1796

@kohya-ss
Copy link
Owner

Thank you for this! And I'm very sorry, but for the schedule-free optimizer, I received a new PR #1600, so I merged it into the sd3 branch (and refactored in #1605). Therefore, I plan to delete this branch in the future. Sorry for the confusion.

I think can make this fix to the sd3 branch myself, however I would be very grateful if you could make the same fix to the sd3 branch.

@rockerBOO
Copy link
Contributor Author

No problem @kohya-ss, I'll make a new PR against the SD3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants