Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new scheduler free optimizer #1315

Closed
wants to merge 4 commits into from
Closed

Conversation

kohya-ss
Copy link
Owner

@kohya-ss kohya-ss commented May 4, 2024

original #1250

@gesen2egee
Copy link
Contributor

In the requirements.txt, schedulefree is missing.

@yuwonlee-prodifi
Copy link

accelerate now officially supports schedulefree since 0.30.0 and you can directly call optimizer.train() and optimizer.eval().
huggingface/accelerate#2631
https://github.com/huggingface/accelerate/releases/tag/v0.30.0

@kohya-ss
Copy link
Owner Author

accelerate now officially supports schedulefree since 0.30.0 and you can directly call optimizer.train() and optimizer.eval(). huggingface/accelerate#2631 https://github.com/huggingface/accelerate/releases/tag/v0.30.0

Thank you for letting me know! This is really nice. I will check it and update this PR.

@yuwonlee-prodifi
Copy link

any update on this?

@67372a
Copy link

67372a commented Sep 1, 2024

Hello @kohya-ss ,

I was wondering, is there any reason scheduler-free-opt is not yet merged into main?

From my testing using schedule-free with Flux, it appears to work as expected. It would be great if this could be merged into main so that it can be made more widely available, as schedule-free works well and simplifies the training process.

Thank you.

@kohya-ss
Copy link
Owner Author

kohya-ss commented Sep 2, 2024

I was wondering, is there any reason scheduler-free-opt is not yet merged into main?

Because there are so many changes, we have to test all scripts with and without it to make sure that existing training still works. It's good news that it works with FLUX. I'll work on it as soon as I have time, so please wait a little longer.

@67372a
Copy link

67372a commented Sep 2, 2024

I was wondering, is there any reason scheduler-free-opt is not yet merged into main?

Because there are so many changes, we have to test all scripts with and without it to make sure that existing training still works. It's good news that it works with FLUX. I'll work on it as soon as I have time, so please wait a little longer.

Hello @kohya-ss ,

I understand and appreciate all the work you are doing. There is definitely interest in schedule free and expanding on it with other schedule free optimizer variants, pending the completion of your implementation and testing.

Thank you.

@kohya-ss kohya-ss closed this Dec 1, 2024
@kohya-ss kohya-ss deleted the scheduler-free-opt branch December 1, 2024 04:11
@kohya-ss kohya-ss restored the scheduler-free-opt branch December 1, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants