openapi-response-validator: adds response arg to errorTransformer callback (closes #875) #876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some minor TS typing. Not sure what you mean by "linting" as there are no scripts/ linting configs defined in the repo.
I developed this on Windows and noticed all of the NPM scripts fail with
'..' is not recognized as an internal or external command, operable program or batch file.
(even with Git Bash). I fixed this locally by runningexport PATH=$PATH:"../../node_modules/.bin"
and replacing the package.json scripts (eg from"test": "../../bin/mocha"
to"mocha -r source-map-support/register -r ts-node/register test/**/*.ts"
).I also noticed the unit tests use the dist/index.js.. That was kind of unexpected, as the test script loads
ts-node
anyway and is thus capable of loadingindex.ts
directly (by doingimport Sut from '../index'
instead ofimport Sut from '..'
intest/data-driven.ts
).