feat(organizations): Add button and modal for inviting new org members TASK-1373 #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ember Conflicts: jsapp/js/theme/kobo/index.ts
put basic data back into select remove todo comment about text input
jamesrkiger
reviewed
Jan 29, 2025
jamesrkiger
reviewed
Jan 29, 2025
| <ButtonNew size='lg' onClick={open}> | ||
| {t('Invite members')} | ||
| </ButtonNew> | ||
| <Modal |
There was a problem hiding this comment.
I'd say let's move this modal to a separate file and load it in the MembersRoute. It's going to get rather large once we start adding in the actual content.
jamesrkiger
requested changes
Jan 29, 2025
moved modal to new file added MMO role check to invite button
jamesrkiger
reviewed
Jan 30, 2025
| <Divider /> | ||
| <Group w='100%' justify='space-between'> | ||
| <Stack gap='xs' pt='xs' pb='xs'> | ||
| <Title order={5}>{t('Invite members')}</Title> |
There was a problem hiding this comment.
Can you check on the typography here? Looks different from the designs:
jamesrkiger
reviewed
Jan 30, 2025
| @@ -3,7 +3,8 @@ | |||
| * For our sanity, use camel case and match key with value. | |||
| */ | |||
| export enum FeatureFlag { | |||
| exampleFeatureEnabled = 'exampleFeatureEnabled', //Comment out when we have active FFs | |||
| //exampleFeatureEnabled = 'exampleFeatureEnabled', //Comment out when we have active FFs | |||
| inviteOrgMembers = 'inviteOrgMembers', | |||
There was a problem hiding this comment.
Suggested change
| inviteOrgMembers = 'inviteOrgMembers', | |
| orgMemberInvitesEnabled = 'orgMemberInvitesEnabled', |
jamesrkiger
requested changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234frontendorbackendunless it's global📣 Summary
Adds UI to invite members to an MMO.
💭 Notes
Just the UI itself, currently does not send or receive any requests. Made with mantine components.
👀 Preview steps
Bug template:
ff_inviteOrgMembers=true