Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Basic Case Management/Dynamic Data Attachments #3057
[Feature] Basic Case Management/Dynamic Data Attachments #3057
Changes from 235 commits
db263ab
4466fb5
9522347
70e9d54
031c653
68e75b4
52c6dfa
937b688
c705eb4
f9b40c0
5c9fd61
7da3dfe
b427945
9c40b2e
5b57f37
358f989
feb85b6
e53c6cf
d6e706c
3688ad4
9fe3c20
973d2e5
436bcd3
217dc11
f7aa3c0
de59b0b
60efe29
a41a66c
42264c5
42e3808
a2672a8
82a8b26
d716cbf
c60e31b
81dfa59
bbc4d65
ff4dc0e
cf5a1ab
b1043e6
ca0ed46
2a8f080
7dd0f69
4cea022
9f2a7ad
c5ee67a
2e2baf9
aa86dfd
b6d1fa4
021b676
2f2387b
045b975
219e243
a0c3ffe
e927b80
15c5d10
435788e
db55f67
de6f676
8ab18b8
f4bec05
7c628f8
b4e6b80
79e6e0c
82c94c7
9522bd7
b52a8da
cb63114
56cdd8c
8b22517
52d7ac3
168eaa5
5a19abf
29d9e5f
d078239
6bce326
2af3488
7c6fcd2
58930a1
e225c6c
b2ec450
b205e00
a3464cd
a39a96b
c321ea9
b1a6087
4ec222b
2d5622b
7e71c4b
5e5e8bb
c9eed76
9404a26
ae9d02d
ea27de1
aab2688
89f6900
c84d0f5
06172dc
c744e32
44ef72c
f9a58d6
4b03813
3bda82d
6b4b848
64d7814
adf48ca
3592a56
fde1395
df22d63
fc7b222
aac03a9
c4ca74c
6563d8d
3518d3b
e3e5ca4
e1bc004
0dbf4e6
cec384e
73188df
acf17c7
3327aa6
65d4ca3
9d1be9d
f7ae1f4
106a536
ee68584
d79f2ea
f6c9638
44d4588
8901d19
e1f1d57
29085a0
38991b6
7a2a3fb
0f123d1
84c0061
e10a2e9
19bcb8b
f4f7690
796b88e
e15f7da
b5889ce
1f66c3b
151d857
fe3ce99
bffe294
59e8489
d14a672
ec05469
5b8e1f6
f7f5a28
d182e42
3facf0a
aede0b2
8d65260
454bf8a
2f46291
9a08a22
5a6ecdc
6c11945
78e0e05
7b1561a
c432312
c4ecec1
bdc2673
0091d8e
0337eb3
67bda2a
8128358
2d9c6c1
1bcd83a
dbb7b47
422311b
e3425ed
6d372ce
82b85e1
fc4cc91
c3bcf98
991757a
7806c16
5bf1055
7e7123d
5fc9edb
c165675
ef6edf5
d14a586
a2fd02c
2341b73
fa4a014
7bcc3e8
6f4dfc1
4116d5f
3aeb2b2
b652dc3
3dac21c
879f03e
fb49886
33c8f0d
fa5a4c3
1107ae6
a66c43f
4046d2f
7fb92fe
903c1f9
4c681b5
e41a8db
7a3976b
36ef28e
f260c20
b3b0f19
ef47ee6
70f8030
e87159d
8fb73e4
0c66fc9
5f336e8
2a93d13
e2006fc
bf5a831
086e07d
d9be384
efe2c3c
93919e7
8c0adb4
6a2f238
622363a
29c8c26
711ef46
57086c8
1b25938
55f8a84
6cef1e1
f02f20f
19791f4
47ae961
de9ae8b
fab8906
5ea066d
ee4fa73
435aa2f
4c8f23a
7622e09
86beb8d
fc51432
af0968e
06ef9b7
fc4e460
b09eaff
d9727c3
b853fff
bf20376
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment why do we need to overwrite the backend responses, i.e. why backend doesn't fromat it that way in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: is it a problem pagination-wise, that we no longer return all
response
properties? We losenext
,prev
,count
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I've left a comment to investigate this later but this would only pop up if there are more than 100 connected projects which I feel like may be an edge case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I use
actions.dataShare.toggleDataSharing
and the asset changes because of that, wouldn'tactions.dataShare.updateColumnFilters.completed.listen()
be interested in the response as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this function needs different parameters to ensure it is clearly different from the other one and wouldn't be misused. So let's make them
uid, isShared
and the function would build thedata
object by itself:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So regardless if the swithch has just been turned on or off, we want an empty
paried-data
array, and the columns are reset to empty (matching backend functionality) after this request goes through with the listener in the modal, so the column filters are also updated.I have the
updateColumnFilters
listener specifically listen for changes to the checkboxes, andtoggleDataSharing
handles cases where we want to set clear the columnsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make a comment for this and add it to the improvements issue :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to above, let's make the parameters
uid, isShared, fields
and builddata
object here:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a comment like above