Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pyxform 1.5.1 #716

Merged
merged 1 commit into from
May 25, 2021
Merged

Upgrade to pyxform 1.5.1 #716

merged 1 commit into from
May 25, 2021

Conversation

jnm
Copy link
Member

@jnm jnm commented May 25, 2021

Description

Upgrade pyxform from 0.15.1 to (a Python 2-compatible fork of) 1.5.1. Please see the change log for a complete list of changes.

Related issues

Closes #604
Supersedes #699 (partially)

* Recognize select questions from the question elements themselves
    instead of checking the bind type; see XLSForm/pyxform#168
* Recognize new error message when a group name matches the form name
    See XLSForm/pyxform#510
* Set `allow_choice_duplicates` to `yes` in cascade test XLSForms
    See XLSForm/pyxform#23; XLSForm/pyxform#373 (comment)
* Update tests to use `default_name` instead of relying on the XLSForm file name
    See XLSForm/pyxform#130
* Update expected XML in tests to match new pyxform behavior:
    * `<model>` becomes `<model odk:xforms-version="1.0.0">`
        * See XLSForm/pyxform#393
    * The bind type for `select` and `select1` becomes `string`
        * See XLSForm/pyxform#168
    * `calculate="concat('uuid:', uuid())"` becomes `jr:preload="uid"`
        * See XLSForm/pyxform#94

This squashed set of changes includes work from #699.
Thanks to @duvld for that contribution.
@jnm jnm self-assigned this May 25, 2021
@jnm jnm merged commit d716664 into master May 25, 2021
@jnm jnm deleted the 604-pyxform-1.5.1-upgrade-on-master branch May 25, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to pyxform 1.3.4
1 participant