Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect icons #3

Merged
merged 2 commits into from
Feb 26, 2017
Merged

Fix incorrect icons #3

merged 2 commits into from
Feb 26, 2017

Conversation

oviradoi
Copy link
Contributor

@oviradoi oviradoi commented Feb 25, 2017 •
edited
Loading

Fixed incorrect icons.
This PR fixes issue #2

@kobilutil
Copy link
Owner

On some execution paths the sfi.iIcon might also contain an overlay index in its upper 8 bits, hence I believe a better fix would be doing the following:
*piIconNormal = sfi.iIcon & 0x00ffffff;

@oviradoi
Copy link
Contributor Author

oviradoi commented Feb 25, 2017 •
edited
Loading

Yes, you are right. I will update my PR to mask it to 0x00ffffff.

@kobilutil kobilutil merged commit 48a2811 into kobilutil:master Feb 26, 2017
@oviradoi oviradoi deleted the fix_icons branch February 27, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oviradoi @kobilutil