Bugs/sdl gettick reset

[bremedios]

Fix usage of SDL_GetTicks() throughout ES. This is separate from the issue causing the Battery % as these changes can have a more widespread impact.

The general fix is to convert from using SDL_GetTicks() which can be reset to 0 to use std::chrono::steady_clock.

[bremedios]

playVideo within es-app/main.cpp

Changes

• total time continually has the total time since the start added to it, instead of time since the last addition. This appears to be a bug because it makes totalTime larger than it should be as well as being inconsistent. Total time will now be the total number of milliseconds since the start of the loop.
• Uses std::chrono::steady_clock to determine how much time (milliseconds) has passed.

I'm not sure if we would ever launch a program that would cause the SDL_GetTicks() to be reset while we're playing a video so although this "could" result in an issue if not fixed, I'm not sure if this would be experienced.

[bremedios]

main within es-app/main.cpp

Changes

• Changed usage of SDL_GetTicks() to std::chrono::steady_clock

Potential Impacts

• Used to determine if it should skip calls to SDL_WaitEventTimeout() and SDL_PollEvent()
• Used to determine if guns should be updated
• Used as the change in time when calling Window::update()

[bremedios]

ScraperHttpRequest/ImageDownloadHandle

Changes

• Changed usage of SDL_GetTicks() to std::chrono::steady_clock

Original code

• Could wait longer than it should to retry a http request if the SDL Tick is reset after the query but before the hold-off expires (and the request is retried.)

Warning

• This change is potentially dangerous and should be reviewed
• This could impact the hold-off logic when we receive a notification for too many requests.

[bremedios]

ApiSystem::extractPdfImages in ApiSystem.cpp

Changes

• Removed usage of SDL_GetTicks() calls as they are no longer used. Likely left over from someones timing code to tell how long it took to extract and process the .PDF files.

[bremedios]

ViewController::reloadAll

Changes

• Changed usage of SDL_GetTicks() to std::chrono::steady_clock.

[bremedios]

es-core: SystemConf::saveSystemConf

Changes

• Changed debugging logging from using SDL_GetTicks() to std::chrono::steady_clock.

[bremedios]

es-core: GuiInfoPopup::update

Changes

• Changed usage of SDL_GetTicks() to std::chrono::steady_clock

Potential Bug Fixes

• Its possible for there to be fade issues if the SDL tick is reset during the fade animation for anything using GuiInfoPopup.

[bremedios]

es-core: VideoComponent::handleStartDelay VideoComponent::update VideoComponent::startVideoWithDelay

Changes

• Changed usage of SDL_GetTicks() to std::chrono::steady_clock

Potential Bug Fixes

• It is possible for there to be fade issues if the SDL tick is reset during the fade animation. (if SDL tick is reset)
• It is possible for it to take longer than it should to call GuiComponent::update (if SDL tick is reset)

[bremedios]

Testing Notes: [5 of 9]

Will track testing status of the changes here.

VideoComponent

• Not Started

GuiInfoPopup

• Confirmed timing for SDL_GetTicks and std::chrono match up when running
• Was able to hit the function when canceling a screen scrape.

Save System Config [Tested]

• This is reporting taking 0ms when executing an NES emulator.

ViewController::Reloadall [Tested]

• This can be triggered by changing the slideshow type Settings->User Interface Settings->Screensaver Settings
• Timing is accurate and correct.

ApiSystem::extractPdf Images [Tested]

• PDFs can be read via the library.

ScraperHttpRequest

• Scrapping via Screenscraper works
• Able to hit update() function
• Not able to hit too many requests

ImageDownloadHandler

• Scraping via Screenscraper works
• Able to hit update() function
• Not able to hit too many requests

Power Save in Main [Tested]

• Confirmed timing for SDL_GetTicks and std::chrono match up when running

Playvideo in main [Tested]

• Confirmed timing for SDL_GetTicks and std::chrono match up when running. Initial commit had a bug where ps_time was used instead of lastTime.

Bugs Created