Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Knulli-specific Device Settings menu with new RGB Settings, moved Power Management and Pico-8 installer there, too #17

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

chrizzo-hb
Copy link

@chrizzo-hb chrizzo-hb commented Jan 13, 2025

Please also merge the corresponding changes to the RGB daemon and the Pico-8 installer here: knulli-cfw/distribution#254

  • introduced a new dedicated ES menu called "Device Settings"
  • introduced an ES-based RGB Settings menu inside "Device Settings"
  • moved Knulli-specific Power Management settings to "Device Settings"
  • introduced the board check concept to ES to hide menus which are irrelevant to the current board (e.g., lid settings on anything but the SP)
  • introduced a Pico-8 installer to ES inside "Device Settings"

IMPORTANT::

  • I have no idea if the Power Management settings still go together with whatever @Mikhailzrick might have recently tinkered with!

* Dedicated menus for tools, RGB, power management
* Install native Pico-8 via GUI
@kthod861
Copy link

Not sure if it's the correct place to talk about that but while you're on the RGB settings, adding a color brightness slider ( not related to the current Brightness which is more the intensity in fact ) could let users get, for example, a white led color ( or any mix ).
Basically a clamped multiplier for the 3 color component ?.

@chrizzo-hb
Copy link
Author

Not sure if it's the correct place to talk about that but while you're on the RGB settings, adding a color brightness slider ( not related to the current Brightness which is more the intensity in fact ) could let users get, for example, a white led color ( or any mix ). Basically a clamped multiplier for the 3 color component ?.

@kthod861 that would be pointless. If you want white light, you simply gotta set all 3 colors to max value (255): https://en.wikipedia.org/wiki/RGB_color_model#/media/File:Venn_diagram_rgb.svg

You can do this already by simply editing the configuration file manually. The only issue is that the colorpicker in the current RGB Settings GUI doesn't offer that color, so you cannot set it from the GUI. I did not implement that GUI myself, so I have no idea why that is.

The new RGB menu already has dedicated sliders for all 3 colors (R, G, and B), so you'll be able to easily mix any color you like, even white.

For now, you can simply edit batocera.conf and set led.colour=255 255 255 if you want white LEDs.

@kthod861
Copy link

Ok, not problem, i was aware of the batocera.conf manual edition, i was just talking for "simple" users, not me, as this tool aim to help "new" users (?) in a batocera mindset.

I found it funny that someone give me a link to RGB color explanation :) i work in the 3d industry since 1999 :)

@chrizzo-hb chrizzo-hb marked this pull request as draft January 14, 2025 01:43
@chrizzo-hb chrizzo-hb changed the title Dedicated menus for Tools, RGB, and Power Management incl. board check in ES Introduced Knulli-specific Device Settings menu with new RGB Settings, moved Power Management and Pico-8 installer there, too Jan 14, 2025
@chrizzo-hb chrizzo-hb marked this pull request as ready for review January 14, 2025 01:48
@acmeplus acmeplus merged commit baebe20 into knulli-cfw:knulli Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants